[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

[eric at webkit.org]

The following commit has been merged in the debian/experimental branch:
commit acd20dcdfe20376c78adb7a5bba4374fa06a7695
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Oct 28 21:38:53 2010 +0000

    2010-10-28  Eric Seidel  <eric at webkit.org>
    
            Reviewed by Adam Barth.
    
            webkit-patch suggest-reviewers -g 260550a6e30b7bf34f16bdb4a5396cf26264fc1c is still very slow
            https://bugs.webkit.org/show_bug.cgi?id=48536
    
            This patch makes it about 40 seconds faster, but it still
            takes 1:40.  This will require more refinement.
    
            The suggested reviewers list appears to be the same.
    
            I think the next step may be to have it stop the search after
            5 reviewers are found.  We never want to suggest 30 people.
    
            * Scripts/webkitpy/common/checkout/scm.py:
             - Using --remove-empty to theoretically stop lookups past
               when a file is removed.  I'm not entirely clear that the option
               does what it says it does.  Example:
               git log --pretty=format:%H -5 --remove-empty -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h
               returns only one commit
               vs.
               git log --pretty=format:%H -5 -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h
               which returns 5.  I was not aware that wx files were ever removed from the repository?
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index 754b908..d5e8d5f 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,28 @@
+2010-10-28  Eric Seidel  <eric at webkit.org>
+
+        Reviewed by Adam Barth.
+
+        webkit-patch suggest-reviewers -g 260550a6e30b7bf34f16bdb4a5396cf26264fc1c is still very slow
+        https://bugs.webkit.org/show_bug.cgi?id=48536
+
+        This patch makes it about 40 seconds faster, but it still
+        takes 1:40.  This will require more refinement.
+
+        The suggested reviewers list appears to be the same.
+
+        I think the next step may be to have it stop the search after
+        5 reviewers are found.  We never want to suggest 30 people.
+
+        * Scripts/webkitpy/common/checkout/scm.py:
+         - Using --remove-empty to theoretically stop lookups past
+           when a file is removed.  I'm not entirely clear that the option
+           does what it says it does.  Example:
+           git log --pretty=format:%H -5 --remove-empty -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h
+           returns only one commit
+           vs.
+           git log --pretty=format:%H -5 -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h
+           which returns 5.  I was not aware that wx files were ever removed from the repository?
+
 2010-10-28  Kinuko Yasuda  <kinuko at chromium.org>
 
         Reviewed by David Levin.
diff --git a/WebKitTools/Scripts/webkitpy/common/checkout/scm.py b/WebKitTools/Scripts/webkitpy/common/checkout/scm.py
index fb3c5a7..9b602c3 100644
--- a/WebKitTools/Scripts/webkitpy/common/checkout/scm.py
+++ b/WebKitTools/Scripts/webkitpy/common/checkout/scm.py
@@ -673,7 +673,8 @@ class Git(SCM):
         return self._changes_files_for_commit(commit_id)
 
     def revisions_changing_file(self, path, limit=5):
-        commit_ids = self.run(["git", "log", "--pretty=format:%H", "-%s" % limit, "--", path]).splitlines()
+        # git rev-list head --remove-empty --limit=5 -- path would be equivalent.
+        commit_ids = self.run(["git", "log", "--remove-empty", "--pretty=format:%H", "-%s" % limit, "--", path]).splitlines()
         return filter(lambda revision: revision, map(self.svn_revision_from_git_commit, commit_ids))
 
     def conflicted_files(self):

-- 
WebKit Debian packaging