[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

commit-queue at webkit.org commit-queue at webkit.org
Wed Dec 22 15:30:14 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 98ffe12dc61e4e9fac8e799a4d3ff21b4fee1b51
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Fri Nov 5 04:47:44 2010 +0000

    2010-11-04  usaini  <usaini08 at gmail.com>
    
            Reviewed by Antonio Gomes.
    
            WebWindowFeatures has a faulty constructor for WebCore::WindowFeatures
            https://bugs.webkit.org/show_bug.cgi?id=48035
    
            * public/WebWindowFeatures.h:
            (WebKit::WebWindowFeatures::WebWindowFeatures): updated the constructor
            that takes in a WebCore::WindowFeature and had it copy all the variables
            over properly so that after calling the constructor WebWindowFeatures is
            always in a valid state. Before, the x,y,width,height booleans may be true, but
            the corresponding int values would not be updated.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
index a7bcbd1..0e0ead7 100644
--- a/WebKit/chromium/ChangeLog
+++ b/WebKit/chromium/ChangeLog
@@ -1,3 +1,17 @@
+2010-11-04  usaini  <usaini08 at gmail.com>
+
+        Reviewed by Antonio Gomes.
+
+        WebWindowFeatures has a faulty constructor for WebCore::WindowFeatures
+        https://bugs.webkit.org/show_bug.cgi?id=48035
+
+        * public/WebWindowFeatures.h:
+        (WebKit::WebWindowFeatures::WebWindowFeatures): updated the constructor
+        that takes in a WebCore::WindowFeature and had it copy all the variables
+        over properly so that after calling the constructor WebWindowFeatures is
+        always in a valid state. Before, the x,y,width,height booleans may be true, but
+        the corresponding int values would not be updated.
+
 2010-11-04  Zhenyao Mo  <zmo at google.com>
 
         Reviewed by Kenneth Russell.
diff --git a/WebKit/chromium/public/WebWindowFeatures.h b/WebKit/chromium/public/WebWindowFeatures.h
index 2e7278a..99d8580 100644
--- a/WebKit/chromium/public/WebWindowFeatures.h
+++ b/WebKit/chromium/public/WebWindowFeatures.h
@@ -81,9 +81,13 @@ struct WebWindowFeatures {
 
 #if WEBKIT_IMPLEMENTATION
     WebWindowFeatures(const WebCore::WindowFeatures& f)
-        : xSet(f.xSet)
+        : x(f.x)
+        , xSet(f.xSet)
+        , y(f.y)
         , ySet(f.ySet)
+        , width(f.width)
         , widthSet(f.widthSet)
+        , height(f.height)
         , heightSet(f.heightSet)
         , menuBarVisible(f.menuBarVisible)
         , statusBarVisible(f.statusBarVisible)

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list