[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
pfeldman at chromium.org
pfeldman at chromium.org
Wed Dec 22 15:30:33 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 88bc1da41662c0871587133e27a7834c7c2d405f
Author: pfeldman at chromium.org <pfeldman at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri Nov 5 10:30:28 2010 +0000
2010-11-05 Pavel Feldman <pfeldman at chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: inspector lags on large resources with numerous <script> tags.
https://bugs.webkit.org/show_bug.cgi?id=49060
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 0b878b4..6641903 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,13 @@
+2010-11-05 Pavel Feldman <pfeldman at chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Web Inspector: inspector lags on large resources with numerous <script> tags.
+ https://bugs.webkit.org/show_bug.cgi?id=49060
+
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
+
2010-11-05 Patrick Gansterer <paroga at webkit.org>
Reviewed by David Kilzer.
diff --git a/WebCore/inspector/front-end/ScriptsPanel.js b/WebCore/inspector/front-end/ScriptsPanel.js
index d861da5..66260f9 100644
--- a/WebCore/inspector/front-end/ScriptsPanel.js
+++ b/WebCore/inspector/front-end/ScriptsPanel.js
@@ -702,16 +702,22 @@ WebInspector.ScriptsPanel.prototype = {
else
script.filesSelectOption = option;
- // Call _showScriptOrResource if the option we just appended ended up being selected.
- // This will happen for the first item added to the menu.
- if (select.options[select.selectedIndex] === option)
+ if (select.options[select.selectedIndex] === option) {
+ // Call _showScriptOrResource if the option we just appended ended up being selected.
+ // This will happen for the first item added to the menu.
this._showScriptOrResource(option.representedObject, {initialLoad: true});
- else {
- // if not first item, check to see if this was the last viewed
+ } else {
+ // If not first item, check to see if this was the last viewed
var url = option.representedObject.url || option.representedObject.sourceURL;
var lastURL = WebInspector.settings.lastViewedScriptFile;
- if (url && url === lastURL)
- this._showScriptOrResource(option.representedObject, {initialLoad: true});
+ if (url && url === lastURL) {
+ // For resources containing multiple <script> tags, we first report them separately and
+ // then glue them all together. They all share url and there is no need to show them all one
+ // by one.
+ var isResource = !!option.representedObject.url;
+ if (isResource || !this.visibleView || !this.visibleView.script || this.visibleView.script.sourceURL !== url)
+ this._showScriptOrResource(option.representedObject, {initialLoad: true});
+ }
}
if (script.worldType === WebInspector.Script.WorldType.EXTENSIONS_WORLD)
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list