[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

mihaip at chromium.org mihaip at chromium.org
Wed Dec 22 15:31:53 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 338229864870e1c4585900392365714bb2d3a59b
Author: mihaip at chromium.org <mihaip at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Fri Nov 5 21:41:24 2010 +0000

    2010-11-05  Mihai Parparita  <mihaip at chromium.org>
    
            Reviewed by Ojan Vafai.
    
            [Chromium] fast/events/stopPropagation-submit.html fails
            https://bugs.webkit.org/show_bug.cgi?id=49078
    
            The test was failing because of a difference between KURL and GURL in
            how forms that have a data: URL action are handled*. Since the actual
            test was testing something else (that stopPropagation does not prevent
            form submissions), using a real page as the target makes the test
            pass everywhere.
    
            * FWIW, it looks like GURL is right, per step 15 of section 4.10.22.3
            (Form submission algorithm) of the HTML 5 spec, data URLs used with GET
            should not be mutated; filed bug 49091 about this.
    
            * fast/events/resources/stopPropagation-submit-target.html: Added.
            * fast/events/stopPropagation-submit.html:
            * platform/chromium/test_expectations.txt:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 82941b6..6c1f97b 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,5 +1,26 @@
 2010-11-05  Mihai Parparita  <mihaip at chromium.org>
 
+        Reviewed by Ojan Vafai.
+
+        [Chromium] fast/events/stopPropagation-submit.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=49078
+        
+        The test was failing because of a difference between KURL and GURL in
+        how forms that have a data: URL action are handled*. Since the actual
+        test was testing something else (that stopPropagation does not prevent
+        form submissions), using a real page as the target makes the test
+        pass everywhere.
+        
+        * FWIW, it looks like GURL is right, per step 15 of section 4.10.22.3 
+        (Form submission algorithm) of the HTML 5 spec, data URLs used with GET
+        should not be mutated; filed bug 49091 about this.
+
+        * fast/events/resources/stopPropagation-submit-target.html: Added.
+        * fast/events/stopPropagation-submit.html:
+        * platform/chromium/test_expectations.txt:
+
+2010-11-05  Mihai Parparita  <mihaip at chromium.org>
+
         Unreviewed; test_expectations fix.
         
         Remove three tests that are no longer flaky. Update a comment about a
diff --git a/LayoutTests/fast/events/resources/stopPropagation-submit-target.html b/LayoutTests/fast/events/resources/stopPropagation-submit-target.html
new file mode 100644
index 0000000..92324fa
--- /dev/null
+++ b/LayoutTests/fast/events/resources/stopPropagation-submit-target.html
@@ -0,0 +1,6 @@
+PASS<br>
+<script>
+document.write(location.search);
+if (window.layoutTestController)
+    layoutTestController.notifyDone();
+</script>
diff --git a/LayoutTests/fast/events/stopPropagation-submit.html b/LayoutTests/fast/events/stopPropagation-submit.html
index 1a94bc8..0e24ebc 100644
--- a/LayoutTests/fast/events/stopPropagation-submit.html
+++ b/LayoutTests/fast/events/stopPropagation-submit.html
@@ -3,7 +3,7 @@ default action. It should not! If the default was prevented, you'll
 see a link below and the text FAIL. On success you will see PASS (and
 ?x=0&y=0).
 </p>
-<form action="data:text/html,<script>if (window.layoutTestController) layoutTestController.notifyDone();</script>PASS<br>">
+<form action="resources/stopPropagation-submit-target.html">
 <input type="image" id="image1" onclick="event.stopPropagation()" value="click here">
 </form>
 <p>
diff --git a/LayoutTests/platform/chromium/test_expectations.txt b/LayoutTests/platform/chromium/test_expectations.txt
index 635ffcd..626d483 100644
--- a/LayoutTests/platform/chromium/test_expectations.txt
+++ b/LayoutTests/platform/chromium/test_expectations.txt
@@ -595,16 +595,6 @@ BUG20551 LINUX WIN : fast/replaced/table-percent-height-text-controls.html = FAI
 
 
 // -----------------------------------------------------------------
-// URL
-// -----------------------------------------------------------------
-
-// Form submission (GET) on non-standard url does not append a query.
-// Implicit expectation in this test is that you can "set query" on a data URL,
-// and it should replace the first "?" substring. This makes absolutely no
-// sense.
-BUG24203 : fast/events/stopPropagation-submit.html = FAIL
-
-// -----------------------------------------------------------------
 // PENDING TESTS (forked to pending/, need to be sent upstream)
 // -----------------------------------------------------------------
 

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list