[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
ap at apple.com
ap at apple.com
Wed Dec 22 15:35:21 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit a382d70c75a2c61bfdde9d879a337c0fbdd0da8e
Author: ap at apple.com <ap at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Mon Nov 8 21:21:01 2010 +0000
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=49201
Crash when closing a page
Handle null frame by passing a 0 frame id (normal ones start from 1).
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::focusedFrameChanged):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::focusedFrameChanged):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKit2/ChangeLog b/WebKit2/ChangeLog
index d4c3907..720121b 100644
--- a/WebKit2/ChangeLog
+++ b/WebKit2/ChangeLog
@@ -1,3 +1,17 @@
+2010-11-08 Alexey Proskuryakov <ap at apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=49201
+ Crash when closing a page
+
+ Handle null frame by passing a 0 frame id (normal ones start from 1).
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::focusedFrameChanged):
+ * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+ (WebKit::WebChromeClient::focusedFrameChanged):
+
2010-11-08 Nate Chapin <japhet at chromium.org>
Reviewed by Alexey Proskuryakov.
diff --git a/WebKit2/UIProcess/WebPageProxy.cpp b/WebKit2/UIProcess/WebPageProxy.cpp
index e5cebf1..b95ed19 100644
--- a/WebKit2/UIProcess/WebPageProxy.cpp
+++ b/WebKit2/UIProcess/WebPageProxy.cpp
@@ -1261,7 +1261,7 @@ void WebPageProxy::didGetSourceForFrame(const String& resultString, uint64_t cal
void WebPageProxy::focusedFrameChanged(uint64_t frameID)
{
- m_focusedFrame = process()->webFrame(frameID);
+ m_focusedFrame = frameID ? process()->webFrame(frameID) : 0;
}
#if USE(ACCELERATED_COMPOSITING)
diff --git a/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp b/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
index 3859fa6..a5d805a 100644
--- a/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
+++ b/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
@@ -113,9 +113,9 @@ void WebChromeClient::focusedNodeChanged(Node*)
void WebChromeClient::focusedFrameChanged(Frame* frame)
{
- WebFrame* webFrame = static_cast<WebFrameLoaderClient*>(frame->loader()->client())->webFrame();
+ WebFrame* webFrame = frame ? static_cast<WebFrameLoaderClient*>(frame->loader()->client())->webFrame() : 0;
- WebProcess::shared().connection()->send(Messages::WebPageProxy::FocusedFrameChanged(webFrame->frameID()), m_page->pageID());
+ WebProcess::shared().connection()->send(Messages::WebPageProxy::FocusedFrameChanged(webFrame ? webFrame->frameID() : 0), m_page->pageID());
}
Page* WebChromeClient::createWindow(Frame*, const FrameLoadRequest&, const WindowFeatures& windowFeatures, const NavigationAction& navigationAction)
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list