[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
caseq at chromium.org
caseq at chromium.org
Wed Dec 22 15:47:26 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit ba2fea76df08b9d1db0a67ad40f0c88f376d27c0
Author: caseq at chromium.org <caseq at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri Nov 12 13:34:18 2010 +0000
2010-11-12 Andrey Kosyakov <caseq at chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [refactoring] do not use absolute positioning for tabbed panes
https://bugs.webkit.org/show_bug.cgi?id=49439
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane):
(WebInspector.TabbedPane.prototype.appendTab):
* inspector/front-end/inspector.css:
(.resource-view.visible):
(.resource-view .tabbed-pane-header):
(.resource-view-cookies):
(.tabbed-pane):
(.tabbed-pane-content):
* inspector/front-end/networkPanel.css:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 6fc07f0..b8cbb4b 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,21 @@
+2010-11-12 Andrey Kosyakov <caseq at chromium.org>
+
+ Reviewed by Yury Semikhatsky.
+
+ Web Inspector: [refactoring] do not use absolute positioning for tabbed panes
+ https://bugs.webkit.org/show_bug.cgi?id=49439
+
+ * inspector/front-end/TabbedPane.js:
+ (WebInspector.TabbedPane):
+ (WebInspector.TabbedPane.prototype.appendTab):
+ * inspector/front-end/inspector.css:
+ (.resource-view.visible):
+ (.resource-view .tabbed-pane-header):
+ (.resource-view-cookies):
+ (.tabbed-pane):
+ (.tabbed-pane-content):
+ * inspector/front-end/networkPanel.css:
+
2010-11-12 John Knottenbelt <jknotten at chromium.org>
Reviewed by Steve Block.
diff --git a/WebCore/inspector/front-end/TabbedPane.js b/WebCore/inspector/front-end/TabbedPane.js
index dec3a0b..1c7b9b0 100644
--- a/WebCore/inspector/front-end/TabbedPane.js
+++ b/WebCore/inspector/front-end/TabbedPane.js
@@ -31,10 +31,9 @@
WebInspector.TabbedPane = function(element)
{
this.element = element || document.createElement("div");
-
- this.tabsElement = document.createElement("div");
- this.tabsElement.className = "tabbed-pane-header";
- this.element.appendChild(this.tabsElement);
+ this.element.addStyleClass("tabbed-pane");
+ this.tabsElement = this.element.createChild("div", "tabbed-pane-header");
+ this.contentElement = this.element.createChild("div", "tabbed-pane-content");
this._tabObjects = {};
}
@@ -46,7 +45,7 @@ WebInspector.TabbedPane.prototype = {
tabElement.textContent = tabTitle;
tabElement.addEventListener("click", tabClickListener, false);
this.tabsElement.appendChild(tabElement);
- this.element.appendChild(contentElement);
+ this.contentElement.appendChild(contentElement);
this._tabObjects[id] = {tab: tabElement, content: contentElement};
},
diff --git a/WebCore/inspector/front-end/inspector.css b/WebCore/inspector/front-end/inspector.css
index 6bf69fe..fdf745a 100644
--- a/WebCore/inspector/front-end/inspector.css
+++ b/WebCore/inspector/front-end/inspector.css
@@ -813,16 +813,12 @@ body.platform-linux .monospace, body.platform-linux .source-code {
}
.resource-view.visible {
- display: block;
+ display: -webkit-box;
}
.resource-view .tabbed-pane-header {
display: none;
- position: absolute;
height: 20px;
- top: 0;
- left: 0;
- right: 0;
background: -webkit-gradient(linear, 0% 0%, 0% 100%, from(rgb(236, 236, 236)), to(rgb(217, 217, 217)));
border-bottom: 1px solid rgb(163, 163, 163);
}
@@ -847,10 +843,6 @@ body.platform-linux .monospace, body.platform-linux .source-code {
overflow: auto;
}
-.resource-view.headers-visible .resource-view-headers {
- top: 20px;
-}
-
.resource-view-headers .outline-disclosure .parent {
-webkit-user-select: none;
font-weight: bold;
@@ -894,11 +886,7 @@ body.platform-linux .monospace, body.platform-linux .source-code {
overflow: auto;
}
-.resource-view.headers-visible .resource-view-content {
- top: 20px;
-}
-
-.resource-view .resource-view-cookies {
+.resource-view-cookies {
position: absolute;
top: 0;
right: 0;
@@ -906,10 +894,7 @@ body.platform-linux .monospace, body.platform-linux .source-code {
bottom: 0;
overflow: auto;
padding: 12px;
-}
-
-.resource-view.headers-visible .resource-view-cookies {
- top: 20px;
+ height: 100%;
}
.resource-view-cookies.table .data-grid {
@@ -2656,6 +2641,16 @@ button.enable-toggle-status-bar-item.toggled-on .glyph {
margin-top: 1px;
}
+.tabbed-pane {
+ -webkit-box-orient: vertical;
+ height: 100%;
+}
+
+.tabbed-pane-content {
+ -webkit-box-flex: 1;
+ position: relative;
+}
+
.tabbed-pane-header {
height: 23px;
padding: 0 10px;
diff --git a/WebCore/inspector/front-end/networkPanel.css b/WebCore/inspector/front-end/networkPanel.css
index 1e0e813..6b6aebe 100644
--- a/WebCore/inspector/front-end/networkPanel.css
+++ b/WebCore/inspector/front-end/networkPanel.css
@@ -624,20 +624,6 @@
padding-top: 5px;
}
-#network-views .resource-view-headers,
-#network-views .resource-view-content,
-#network-views .resource-view-cookies
-{
- top: 31px;
-}
-
-#network-views.small .resource-view-headers,
-#network-views.small .resource-view-content,
-#network-views.small .resource-view-cookies
-{
- top: 23px;
-}
-
.network.panel:not(.viewing-resource) .data-grid tr.selected {
background-color: transparent;
color: black;
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list