[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
eric.carlson at apple.com
eric.carlson at apple.com
Wed Dec 22 15:49:06 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 49dca9dcb833d232988718faa9a574579104b7b6
Author: eric.carlson at apple.com <eric.carlson at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri Nov 12 22:40:10 2010 +0000
2010-11-12 Eric Carlson <eric.carlson at apple.com>
Reviewed by Simon Fraser.
Remove unused code from HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=49451
Just removing code, so no new tests.
* html/HTMLMediaElement.cpp: Removed unused functions.
* html/HTMLMediaElement.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index afaacd4..dcbd910 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2010-11-12 Eric Carlson <eric.carlson at apple.com>
+
+ Reviewed by Simon Fraser.
+
+ Remove unused code from HTMLMediaElement
+ https://bugs.webkit.org/show_bug.cgi?id=49451
+
+ Just removing code, so no new tests.
+
+ * html/HTMLMediaElement.cpp: Removed unused functions.
+ * html/HTMLMediaElement.h:
+
2010-11-12 Ryosuke Niwa <rniwa at webkit.org>
Unreviewed XCode project fix.
diff --git a/WebCore/html/HTMLMediaElement.cpp b/WebCore/html/HTMLMediaElement.cpp
index af14e6a..c96bb1e 100644
--- a/WebCore/html/HTMLMediaElement.cpp
+++ b/WebCore/html/HTMLMediaElement.cpp
@@ -441,42 +441,6 @@ void HTMLMediaElement::loadTimerFired(Timer<HTMLMediaElement>*)
loadInternal();
}
-static String serializeTimeOffset(float time)
-{
- String timeString = String::number(time);
- // FIXME serialize time offset values properly (format not specified yet)
- timeString.append("s");
- return timeString;
-}
-
-static float parseTimeOffset(const String& timeString, bool* ok = 0)
-{
- const UChar* characters = timeString.characters();
- unsigned length = timeString.length();
-
- if (length && characters[length - 1] == 's')
- length--;
-
- // FIXME parse time offset values (format not specified yet)
- float val = charactersToFloat(characters, length, ok);
- return val;
-}
-
-float HTMLMediaElement::getTimeOffsetAttribute(const QualifiedName& name, float valueOnError) const
-{
- bool ok;
- String timeString = getAttribute(name);
- float result = parseTimeOffset(timeString, &ok);
- if (ok)
- return result;
- return valueOnError;
-}
-
-void HTMLMediaElement::setTimeOffsetAttribute(const QualifiedName& name, float value)
-{
- setAttribute(name, serializeTimeOffset(value));
-}
-
PassRefPtr<MediaError> HTMLMediaElement::error() const
{
return m_error;
diff --git a/WebCore/html/HTMLMediaElement.h b/WebCore/html/HTMLMediaElement.h
index ffcee5f..61221b8 100644
--- a/WebCore/html/HTMLMediaElement.h
+++ b/WebCore/html/HTMLMediaElement.h
@@ -197,9 +197,6 @@ private:
virtual void defaultEventHandler(Event*);
- float getTimeOffsetAttribute(const QualifiedName&, float valueOnError) const;
- void setTimeOffsetAttribute(const QualifiedName&, float value);
-
// ActiveDOMObject functions.
virtual bool canSuspend() const;
virtual void suspend(ReasonForSuspension);
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list