[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

[apavlov at chromium.org]

The following commit has been merged in the debian/experimental branch:
commit e109de53d265c991509486567bd53a3da9adf275
Author: apavlov at chromium.org <apavlov at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Nov 18 14:42:58 2010 +0000

    2010-11-18  Alexander Pavlov  <apavlov at chromium.org>
    
            Reviewed by Pavel Feldman.
    
            [v8] fast/css/getFloatValueForUnit.html fails since http://trac.webkit.org/changeset/72189
            https://bugs.webkit.org/show_bug.cgi?id=49656
    
            WebCore:
            * bindings/scripts/CodeGeneratorV8.pm:
    
            LayoutTests:
            * platform/chromium/test_expectations.txt:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 2343ec4..0ab7b0c 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,14 @@
+2010-11-18  Alexander Pavlov  <apavlov at chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        [v8] fast/css/getFloatValueForUnit.html fails since http://trac.webkit.org/changeset/72189
+        https://bugs.webkit.org/show_bug.cgi?id=49656
+
+        Re-enable fast/css/getFloatValueForUnit.html once the generated WebCore binding is fixed.
+
+        * platform/chromium/test_expectations.txt:
+
 2010-11-18  Nikolas Zimmermann  <nzimmermann at rim.com>
 
         Reviewed by Dirk Schulze.
diff --git a/LayoutTests/platform/chromium/test_expectations.txt b/LayoutTests/platform/chromium/test_expectations.txt
index ad112a7..09579dd 100644
--- a/LayoutTests/platform/chromium/test_expectations.txt
+++ b/LayoutTests/platform/chromium/test_expectations.txt
@@ -3196,10 +3196,6 @@ BUGWK49477 WIN LINUX : fast/canvas/canvas-arc-360-winding.html = TEXT
 BUGWK49653 WIN LINUX MAC : fast/dom/setPrimitiveValue-exceptions.html = TEXT CRASH IMAGE
 BUGWK49653 WIN LINUX MAC : fast/css/line-height-determined-by-primary-font.html = IMAGE+TEXT IMAGE
 
-// Regression after http://trac.webkit.org/changeset/72189
-BUGWK49653 WIN LINUX MAC : fast/css/getFloatValueForUnit.html = TEXT
-
-
 // Due to WebKit r72141 (needs rebaseline upstream?).
 BUG_LEVIN : fast/compact/001.html = IMAGE+TEXT IMAGE
 BUG_LEVIN LINUX WIN : fast/parser/style-script-head-test.html = TEXT
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index f5ab3af..eb1687f 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,14 @@
+2010-11-18  Alexander Pavlov  <apavlov at chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        [v8] fast/css/getFloatValueForUnit.html fails since http://trac.webkit.org/changeset/72189
+        https://bugs.webkit.org/show_bug.cgi?id=49656
+
+        Explicitly specify indexerType for the generation of V8WebKitCSSTransformValue binding.
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+
 2010-11-18  Nikolas Zimmermann  <nzimmermann at rim.com>
 
         Reviewed by Dirk Schulze.
diff --git a/WebCore/bindings/scripts/CodeGeneratorV8.pm b/WebCore/bindings/scripts/CodeGeneratorV8.pm
index d811ef8..a86efdc 100644
--- a/WebCore/bindings/scripts/CodeGeneratorV8.pm
+++ b/WebCore/bindings/scripts/CodeGeneratorV8.pm
@@ -1515,11 +1515,6 @@ sub GenerateImplementationIndexer
     if ($interfaceName eq "HTMLOptionsCollection") {
         $hasGetter = 1;
     }
-    # FIXME: If the parent interface of $dataNode already has
-    # HasIndexGetter, we don't need to handle the getter here.
-    if ($interfaceName eq "WebKitCSSTransformValue") {
-        $hasGetter = 0;
-    }
 
     # FIXME: Investigate and remove this nastinesss. In V8, named property handling and indexer handling are apparently decoupled,
     # which means that object[X] where X is a number doesn't reach named property indexer. So we need to provide
@@ -1545,6 +1540,13 @@ sub GenerateImplementationIndexer
         $indexerType = "WebKitCSSKeyframeRule";
     }
 
+    # FIXME: The item() getter is not inherited from CSSValueList, seemingly due to the way
+    # the CodeGenerator->AddMethodsConstantsAndAttributesFromParentClasses() method works,
+    # so we need to set the indexerType manually in this case.
+    if ($interfaceName eq "WebKitCSSTransformValue") {
+        $indexerType = "CSSValue";
+    }
+
     if ($indexerType && !$hasCustomSetter) {
         if ($indexerType eq "DOMString") {
             my $conversion = $indexer->extendedAttributes->{"ConvertNullStringTo"};

-- 
WebKit Debian packaging