[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

eric at webkit.org eric at webkit.org
Wed Dec 22 13:20:33 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit a188d4f52dc8ba3dc3ea34c7bf56405aa9fd69ab
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Sat Sep 11 23:25:17 2010 +0000

    2010-09-11  Eric Seidel  <eric at webkit.org>
    
            Reviewed by Adam Barth.
    
            Remove unneeded Empty Queue messages
            https://bugs.webkit.org/show_bug.cgi?id=45602
    
            We already have a /gc job to delete these.
            recentstatus.py is already smart enough to use the
            most recent of the workitems last update or the most recent status,
            so removing these should not change the _last_status_date() return
            value more than a few milliseconds.
    
            These messages just spam the recent status log.
    
            * Scripts/webkitpy/tool/commands/queues.py:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index ee787e6..d911754 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,20 @@
+2010-09-11  Eric Seidel  <eric at webkit.org>
+
+        Reviewed by Adam Barth.
+
+        Remove unneeded Empty Queue messages
+        https://bugs.webkit.org/show_bug.cgi?id=45602
+
+        We already have a /gc job to delete these.
+        recentstatus.py is already smart enough to use the
+        most recent of the workitems last update or the most recent status,
+        so removing these should not change the _last_status_date() return
+        value more than a few milliseconds.
+
+        These messages just spam the recent status log.
+
+        * Scripts/webkitpy/tool/commands/queues.py:
+
 2010-09-11  Mihai Parparita  <mihaip at chromium.org>
 
         Reviewed by Adam Barth.
diff --git a/WebKitTools/Scripts/webkitpy/tool/commands/queues.py b/WebKitTools/Scripts/webkitpy/tool/commands/queues.py
index 127e7ef..248d1e5 100644
--- a/WebKitTools/Scripts/webkitpy/tool/commands/queues.py
+++ b/WebKitTools/Scripts/webkitpy/tool/commands/queues.py
@@ -194,7 +194,6 @@ class CommitQueue(AbstractPatchQueue, StepSequenceErrorHandler):
         patches = sorted(patches, self._patch_cmp)
         self._update_work_items([patch.id() for patch in patches])
         if not patches:
-            self._update_status("Empty queue")
             return None
         # Only bother logging if we have patches in the queue.
         self.log_progress([patch.id() for patch in patches])
@@ -379,7 +378,6 @@ class AbstractReviewQueue(AbstractPatchQueue, PersistentPatchCollectionDelegate,
         patch_id = self._patches.next()
         if patch_id:
             return self.tool.bugs.fetch_attachment(patch_id)
-        self._update_status("Empty queue")
 
     def should_proceed_with_work_item(self, patch):
         raise NotImplementedError, "subclasses must implement"

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list