[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
cfleizach at apple.com
cfleizach at apple.com
Wed Dec 22 13:40:29 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit da47efddf77118c2d2a63429dd81337ef1cbda02
Author: cfleizach at apple.com <cfleizach at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Sep 23 01:27:03 2010 +0000
WebCore: AX: aria-hidden change doesn't update the ax tree
https://bugs.webkit.org/show_bug.cgi?id=45836
Reviewed by Darin Adler.
Test: accessibility/aria-hidden-update.html
* dom/Element.cpp:
(WebCore::Element::updateAfterAttributeChanged):
LayoutTests: [FileSystem] Fix Flags handling in DirectoryEntry custom binding code
https://bugs.webkit.org/show_bug.cgi?id=46028
Patch by Kinuko Yasuda <kinuko at chromium.org> on 2010-09-22
Reviewed by Dumitru Daniliuc.
* fast/filesystem/flags-passing-expected.txt: Added.
* fast/filesystem/flags-passing.html: Added.
* fast/filesystem/script-tests/TEMPLATE.html: Added.
* fast/filesystem/script-tests/flags-passing.js: Added.
* platform/gtk/Skipped: FileSystem API not supported on gtk.
* platform/mac/Skipped: FileSystem API not supported on mac.
* platform/qt/Skipped: FileSystem API not supported on qt.
* platform/win/Skipped: FileSystem API not supported on win.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 24fc53d..9f76445 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -2332,6 +2332,16 @@
2010-09-15 Chris Fleizach <cfleizach at apple.com>
+ Reviewed by Darin Adler.
+
+ AX: aria-hidden change doesn't update the ax tree
+ https://bugs.webkit.org/show_bug.cgi?id=45836
+
+ * accessibility/aria-hidden-update-expected.txt: Added.
+ * accessibility/aria-hidden-update.html: Added.
+
+2010-09-15 Chris Fleizach <cfleizach at apple.com>
+
AX: when text is auto-truncated, accessibility bounds are wrong
https://bugs.webkit.org/show_bug.cgi?id=45793
diff --git a/LayoutTests/accessibility/aria-hidden-update-expected.txt b/LayoutTests/accessibility/aria-hidden-update-expected.txt
new file mode 100644
index 0000000..93ac375
--- /dev/null
+++ b/LayoutTests/accessibility/aria-hidden-update-expected.txt
@@ -0,0 +1,20 @@
+Button 1
+Button 2
+Button 3
+This test makes sure that when aria-hidden changes, the AX hierarchy is updated.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS parent.childAtIndex(0).isEqual(button1) is true
+PASS parent.childAtIndex(1).isEqual(button2) is true
+PASS parent.childAtIndex(2).isEqual(button3) is true
+PASS parent.childAtIndex(0).isEqual(button1) is true
+PASS parent.childAtIndex(1).isEqual(button3) is true
+PASS parent.childAtIndex(0).isEqual(button3) is true
+PASS parent.childAtIndex(0).isEqual(button2) is true
+PASS parent.childAtIndex(1).isEqual(button3) is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
diff --git a/LayoutTests/accessibility/aria-hidden-update.html b/LayoutTests/accessibility/aria-hidden-update.html
new file mode 100644
index 0000000..5aa7b8d
--- /dev/null
+++ b/LayoutTests/accessibility/aria-hidden-update.html
@@ -0,0 +1,64 @@
+<html>
+<html>
+<head>
+<link rel="stylesheet" href="../fast/js/resources/js-test-style.css">
+<script>
+var successfullyParsed = false;
+</script>
+<script src="../fast/js/resources/js-test-pre.js"></script>
+</head>
+<body id="body">
+
+ <div role="group" tabindex="0" id="parent">
+ <div role="button" id="button1" tabindex="0">Button 1</div>
+ <div role="button" id="button2" tabindex="0">Button 2</div>
+ <div role="button" id="button3" tabindex="0">Button 3</div>
+
+ </div>
+
+
+ <p id="description"></p>
+ <div id="console"></div>
+
+ <script>
+ if (window.accessibilityController) {
+ description("This test makes sure that when aria-hidden changes, the AX hierarchy is updated.");
+
+ // Get the parent element.
+ document.getElementById("parent").focus();
+ var parent = accessibilityController.focusedElement;
+
+ // Get all three children.
+ document.getElementById("button1").focus();
+ var button1 = accessibilityController.focusedElement;
+ document.getElementById("button2").focus();
+ var button2 = accessibilityController.focusedElement;
+ document.getElementById("button3").focus();
+ var button3 = accessibilityController.focusedElement;
+
+ // Verify that the 3 children are present.
+ shouldBeTrue("parent.childAtIndex(0).isEqual(button1)");
+ shouldBeTrue("parent.childAtIndex(1).isEqual(button2)");
+ shouldBeTrue("parent.childAtIndex(2).isEqual(button3)");
+
+ // Make the 2nd button hidden. Only 1 and 3 should be present.
+ document.getElementById("button2").setAttribute("aria-hidden", "true");
+ shouldBeTrue("parent.childAtIndex(0).isEqual(button1)");
+ shouldBeTrue("parent.childAtIndex(1).isEqual(button3)");
+
+ // Make the 1st button hidden. Only 3 should be present.
+ document.getElementById("button1").setAttribute("aria-hidden", "true");
+ shouldBeTrue("parent.childAtIndex(0).isEqual(button3)");
+
+ // Make the 2nd button not hidden. 2 and 3 should be present.
+ document.getElementById("button2").setAttribute("aria-hidden", "false");
+ shouldBeTrue("parent.childAtIndex(0).isEqual(button2)");
+ shouldBeTrue("parent.childAtIndex(1).isEqual(button3)");
+
+ }
+ successfullyParsed = true;
+ </script>
+
+<script src="../fast/js/resources/js-test-post.js"></script>
+</body>
+</html>
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index b85d142..3d688fb 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2010-09-22 Chris Fleizach <cfleizach at apple.com>
+
+ Reviewed by Darin Adler.
+
+ AX: aria-hidden change doesn't update the ax tree
+ https://bugs.webkit.org/show_bug.cgi?id=45836
+
+ Test: accessibility/aria-hidden-update.html
+
+ * dom/Element.cpp:
+ (WebCore::Element::updateAfterAttributeChanged):
+
2010-09-22 Kinuko Yasuda <kinuko at chromium.org>
Reviewed by Dumitru Daniliuc.
diff --git a/WebCore/dom/Element.cpp b/WebCore/dom/Element.cpp
index 0ba2e88..5c4e82b 100644
--- a/WebCore/dom/Element.cpp
+++ b/WebCore/dom/Element.cpp
@@ -657,6 +657,8 @@ void Element::updateAfterAttributeChanged(Attribute* attr)
document()->axObjectCache()->selectedChildrenChanged(renderer());
else if (attrName == aria_expandedAttr)
document()->axObjectCache()->handleAriaExpandedChange(renderer());
+ else if (attrName == aria_hiddenAttr)
+ document()->axObjectCache()->childrenChanged(renderer());
}
void Element::recalcStyleIfNeededAfterAttributeChanged(Attribute* attr)
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list