[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
abarth at webkit.org
abarth at webkit.org
Wed Dec 22 13:40:43 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit e7231de5fd132eecbc0b4aae94c471b53ba23d61
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Sep 23 03:42:05 2010 +0000
2010-09-22 Adam Barth <abarth at webkit.org>
Reviewed by Eric Seidel.
Add link to bug to review page
https://bugs.webkit.org/show_bug.cgi?id=46192
To make room for the link, I moved the help text to the top of the page
and tweaked the language to help folks discover that you can select
context using the line numbers.
Also, move more text to sans-serif since that fits in better with the
pretty-patch fonts.
* PrettyPatch/PrettyPatch.rb:
* code-review.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/BugsSite/ChangeLog b/BugsSite/ChangeLog
index fdf2d62..48dcbbf 100644
--- a/BugsSite/ChangeLog
+++ b/BugsSite/ChangeLog
@@ -1,3 +1,20 @@
+2010-09-22 Adam Barth <abarth at webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Add link to bug to review page
+ https://bugs.webkit.org/show_bug.cgi?id=46192
+
+ To make room for the link, I moved the help text to the top of the page
+ and tweaked the language to help folks discover that you can select
+ context using the line numbers.
+
+ Also, move more text to sans-serif since that fits in better with the
+ pretty-patch fonts.
+
+ * PrettyPatch/PrettyPatch.rb:
+ * code-review.js:
+
2010-09-21 Adam Barth <abarth at webkit.org>
Unreviewed.
diff --git a/BugsSite/PrettyPatch/PrettyPatch.rb b/BugsSite/PrettyPatch/PrettyPatch.rb
index d21b3ac..c8e3a7d 100644
--- a/BugsSite/PrettyPatch/PrettyPatch.rb
+++ b/BugsSite/PrettyPatch/PrettyPatch.rb
@@ -213,20 +213,17 @@ body {
right: 0;
border-top: 1px solid #ddd;
background-color: #eee;
+ font-family: sans-serif;
}
#toolbar .actions {
float: left;
}
-#toolbar .message {
+#toolbar .links {
float: right;
}
-#toolbar .commentStatus {
- font-style:italic
-}
-
.winter {
position: fixed;
z-index: 5;
@@ -271,6 +268,15 @@ body {
font-style: italic;
}
+.message {
+ font-size: small;
+ font-family: sans-serif;
+}
+
+.commentStatus {
+ font-style: italic;
+}
+
.description {
font-style: italic;
}
@@ -306,7 +312,7 @@ body {
}
</style>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script>
-<script src="code-review.js?version=11"></script>
+<script src="code-review.js?version=12"></script>
EOF
def self.revisionOrDescription(string)
diff --git a/BugsSite/code-review.js b/BugsSite/code-review.js
index 8f66335..8339d61 100644
--- a/BugsSite/code-review.js
+++ b/BugsSite/code-review.js
@@ -161,7 +161,7 @@
descriptor = comments.length + ' comment';
if (comments.length > 1)
descriptor += 's';
- $('#toolbar .commentStatus').text('This patch has ' + descriptor + '. Scroll through them with the "n" and "p" keys.');
+ $('.message .commentStatus').text('This patch has ' + descriptor + '. Scroll through them with the "n" and "p" keys.');
}
function scanForComments(author, text) {
@@ -240,6 +240,7 @@
var details = $(data);
addFlagsForAttachment(details);
$('#toolbar .actions').append($('<iframe class="statusBubble" src="https://webkit-commit-queue.appspot.com/status-bubble/' + attachment_id + '" scrolling="no"></iframe>'));
+ $('#toolbar .bugLink').html('<a href="/show_bug.cgi?id=' + bug_id + '" target="_blank">Bug ' + bug_id + '</a>');
});
}
@@ -254,7 +255,8 @@
$(document).ready(function() {
crawlDiff();
fetchHistory();
- $(document.body).prepend('<div id="toolbar"><div class="actions"><button id="preview_comments">Preview</button><button id="post_comments">Publish</button></div><div class="message"> <span class="commentStatus"></span> <span class="help">Double-click a line or click or drag on line numbers to add a comment.</span></div></div>');
+ $(document.body).prepend('<div id="message"><div class="help">Double-click a line or select line numbers to add a comment.</div><div class="commentStatus"></div></div>');
+ $(document.body).prepend('<div id="toolbar"><div class="actions"><button id="preview_comments">Preview</button><button id="post_comments">Publish</button></div><div class="links"><span class="bugLink"></span></div>');
$(document.body).prepend('<div id="comment_form" class="inactive"><div class="winter"></div><div class="lightbox"><iframe id="reviewform" src="attachment.cgi?id=' + attachment_id + '&action=reviewform"></iframe></div></div>');
$(document.body).append('<div class="overallComments"><div class="description">Overall comments:</div><textarea></textarea></div>');
});
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list