[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

commit-queue at webkit.org commit-queue at webkit.org
Wed Dec 22 13:54:53 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 393c30861286079af0b8dd9d96bd1e773f774232
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Sep 29 16:43:01 2010 +0000

    2010-09-29  João Paulo Rechi Vita  <jprvita at profusion.mobi>
    
            Reviewed by Antonio Gomes.
    
            [EFL] General small fixes.
            https://bugs.webkit.org/show_bug.cgi?id=46813
    
            This commit spots a comparison between signed and unsigned integer
            expressions, a missing return and a never-called function.
    
            No new tests since no new funcionality has been added.
    
            * platform/efl/SharedBufferEfl.cpp:
            (WebCore::SharedBuffer::createWithContentsOfFile):
    2010-09-29  João Paulo Rechi Vita  <jprvita at profusion.mobi>
    
            Reviewed by Antonio Gomes.
    
            [EFL] General small fixes.
            https://bugs.webkit.org/show_bug.cgi?id=46813
    
            This commit spots a comparison between signed and unsigned integer
            expressions, a missing return and a never-called function.
    
            * WebCoreSupport/FullscreenVideoControllerEfl.cpp:
            (FullscreenVideoController::canPlay):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index c660e9d..e81112f 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,18 @@
+2010-09-29  João Paulo Rechi Vita  <jprvita at profusion.mobi>
+
+        Reviewed by Antonio Gomes.
+
+        [EFL] General small fixes.
+        https://bugs.webkit.org/show_bug.cgi?id=46813
+
+        This commit spots a comparison between signed and unsigned integer
+        expressions, a missing return and a never-called function.
+
+        No new tests since no new funcionality has been added.
+
+        * platform/efl/SharedBufferEfl.cpp:
+        (WebCore::SharedBuffer::createWithContentsOfFile):
+
 2010-09-29  Philippe Normand  <pnormand at igalia.com>
 
         Reviewed by Gustavo Noronha Silva.
diff --git a/WebCore/platform/efl/SharedBufferEfl.cpp b/WebCore/platform/efl/SharedBufferEfl.cpp
index 1025e33..23769ab 100644
--- a/WebCore/platform/efl/SharedBufferEfl.cpp
+++ b/WebCore/platform/efl/SharedBufferEfl.cpp
@@ -56,7 +56,7 @@ PassRefPtr<SharedBuffer> SharedBuffer::createWithContentsOfFile(const String& fi
 
     result = SharedBuffer::create();
     result->m_buffer.resize(fileStat.st_size);
-    if (result->m_buffer.size() != fileStat.st_size) {
+    if (result->m_buffer.size() != static_cast<unsigned>(fileStat.st_size)) {
         fclose(file);
         return 0;
     }
diff --git a/WebKit/efl/ChangeLog b/WebKit/efl/ChangeLog
index 7c6afe9..7659be0 100644
--- a/WebKit/efl/ChangeLog
+++ b/WebKit/efl/ChangeLog
@@ -1,3 +1,16 @@
+2010-09-29  João Paulo Rechi Vita  <jprvita at profusion.mobi>
+
+        Reviewed by Antonio Gomes.
+
+        [EFL] General small fixes.
+        https://bugs.webkit.org/show_bug.cgi?id=46813
+
+        This commit spots a comparison between signed and unsigned integer
+        expressions, a missing return and a never-called function.
+
+        * WebCoreSupport/FullscreenVideoControllerEfl.cpp:
+        (FullscreenVideoController::canPlay):
+
 2010-09-28  Jenn Braithwaite  <jennb at chromium.org>
 
         Reviewed by Dmitry Titov.
diff --git a/WebKit/efl/WebCoreSupport/FullscreenVideoControllerEfl.cpp b/WebKit/efl/WebCoreSupport/FullscreenVideoControllerEfl.cpp
index 6e5d599..70deaef 100644
--- a/WebKit/efl/WebCoreSupport/FullscreenVideoControllerEfl.cpp
+++ b/WebKit/efl/WebCoreSupport/FullscreenVideoControllerEfl.cpp
@@ -91,6 +91,7 @@ void FullscreenVideoController::exitFullscreen()
 bool FullscreenVideoController::canPlay() const
 {
     notImplemented();
+    return false;
 }
 
 void FullscreenVideoController::play()
@@ -178,11 +179,6 @@ void FullscreenVideoController::endSeek()
     notImplemented();
 }
 
-static String timeToString(float time)
-{
-    notImplemented();
-}
-
 bool FullscreenVideoController::updateHudProgressBar()
 {
     notImplemented();

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list