[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
abarth at webkit.org
abarth at webkit.org
Wed Dec 22 13:58:29 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 2aba7f83903f00b6a6f055003aa97968701fdb38
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Sep 30 18:50:55 2010 +0000
2010-09-30 Adam Barth <abarth at webkit.org>
Reviewed by Eric Seidel.
webkit-patch find-flaky-tests should print results URLs
https://bugs.webkit.org/show_bug.cgi?id=46917
Printing out the results URL makes find-flaky-tests more actionable
because you can see what happens when a test fails. The output from
the script is still pretty noisy, but it seems useful.
* Scripts/webkitpy/tool/commands/queries.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index 13b3249..4db6a78 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,16 @@
+2010-09-30 Adam Barth <abarth at webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ webkit-patch find-flaky-tests should print results URLs
+ https://bugs.webkit.org/show_bug.cgi?id=46917
+
+ Printing out the results URL makes find-flaky-tests more actionable
+ because you can see what happens when a test fails. The output from
+ the script is still pretty noisy, but it seems useful.
+
+ * Scripts/webkitpy/tool/commands/queries.py:
+
2010-09-30 Chris Marrin <cmarrin at apple.com>
Reviewed by Simon Fraser.
diff --git a/WebKitTools/Scripts/webkitpy/tool/commands/queries.py b/WebKitTools/Scripts/webkitpy/tool/commands/queries.py
index 620afbc..478fac2 100644
--- a/WebKitTools/Scripts/webkitpy/tool/commands/queries.py
+++ b/WebKitTools/Scripts/webkitpy/tool/commands/queries.py
@@ -278,18 +278,18 @@ class FindFlakyTests(AbstractDeclarativeCommand):
build = builder.build_for_revision(revision, allow_failed_lookups=True)
if not build:
print "No build for %s" % revision
- return None
+ return (None, None)
results = build.layout_test_results()
if not results:
print "No results build %s (r%s)" % (build._number, build.revision())
- return None
+ return (None, None)
failures = set(results.failing_tests())
if len(failures) >= 20:
# FIXME: We may need to move this logic into the LayoutTestResults class.
# The buildbot stops runs after 20 failures so we don't have full results to work with here.
print "Too many failures in build %s (r%s), ignoring." % (build._number, build.revision())
- return None
- return failures
+ return (None, None)
+ return (build, failures)
def _increment_statistics(self, flaky_tests, flaky_test_statistics):
for test in flaky_tests:
@@ -306,20 +306,23 @@ class FindFlakyTests(AbstractDeclarativeCommand):
flaky_test_statistics = {}
all_previous_failures = set([])
one_time_previous_failures = set([])
+ previous_build = None
for i in range(limit):
revision = start_revision - i
print "Analyzing %s ... " % revision,
- failures = self._find_failures(builder, revision)
+ (build, failures) = self._find_failures(builder, revision)
if failures == None:
# Notice that we don't loop on the empty set!
continue
print "has %s failures" % len(failures)
flaky_tests = one_time_previous_failures - failures
if flaky_tests:
- print "Flaky tests: %s" % sorted(flaky_tests)
+ print "Flaky tests: %s %s" % (sorted(flaky_tests),
+ previous_build.results_url())
self._increment_statistics(flaky_tests, flaky_test_statistics)
one_time_previous_failures = failures - all_previous_failures
all_previous_failures = failures
+ previous_build = build
self._print_statistics(flaky_test_statistics)
def _builder_to_analyze(self):
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list