[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

crogers at google.com crogers at google.com
Wed Dec 22 14:11:17 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 7ec20b1b7defef28a8488425a21fe6dae87b2ad4
Author: crogers at google.com <crogers at google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Oct 5 08:27:14 2010 +0000

    2010-10-05  Chris Rogers  <crogers at google.com>
    
            Reviewed by Kenneth Russell.
    
            Add BiquadDSPKernel files
            https://bugs.webkit.org/show_bug.cgi?id=46528
    
            No new tests since audio API is not yet implemented.
    
            * webaudio/BiquadDSPKernel.cpp: Added.
            (WebCore::BiquadDSPKernel::process):
            * webaudio/BiquadDSPKernel.h: Added.
            (WebCore::BiquadDSPKernel::BiquadDSPKernel):
            (WebCore::BiquadDSPKernel::reset):
            (WebCore::BiquadDSPKernel::biquadProcessor):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index f9c73a4..4d70b1a 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,5 +1,21 @@
 2010-10-05  Chris Rogers  <crogers at google.com>
 
+        Reviewed by Kenneth Russell.
+
+        Add BiquadDSPKernel files
+        https://bugs.webkit.org/show_bug.cgi?id=46528
+
+        No new tests since audio API is not yet implemented.
+
+        * webaudio/BiquadDSPKernel.cpp: Added.
+        (WebCore::BiquadDSPKernel::process):
+        * webaudio/BiquadDSPKernel.h: Added.
+        (WebCore::BiquadDSPKernel::BiquadDSPKernel):
+        (WebCore::BiquadDSPKernel::reset):
+        (WebCore::BiquadDSPKernel::biquadProcessor):
+
+2010-10-05  Chris Rogers  <crogers at google.com>
+
         Reviewed by James Robinson.
 
         Fix AudioContext to use new HRTFDatabaseLoader API
diff --git a/WebCore/webaudio/BiquadDSPKernel.cpp b/WebCore/webaudio/BiquadDSPKernel.cpp
new file mode 100644
index 0000000..a4b28be
--- /dev/null
+++ b/WebCore/webaudio/BiquadDSPKernel.cpp
@@ -0,0 +1,77 @@
+/*
+ * Copyright (C) 2010, Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1.  Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2.  Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+
+#if ENABLE(WEB_AUDIO)
+
+#include "BiquadDSPKernel.h"
+
+#include "BiquadProcessor.h"
+
+namespace WebCore {
+
+void BiquadDSPKernel::process(const float* source, float* destination, size_t framesToProcess)
+{
+    ASSERT(source && destination && biquadProcessor());
+    
+    // Recompute filter coefficients if any of the parameters have changed.
+    // FIXME: as an optimization, implement a way that a Biquad object can simply copy its internal filter coefficients from another Biquad object.
+    // Then re-factor this code to only run for the first BiquadDSPKernel of each BiquadProcessor.
+    if (biquadProcessor()->filterCoefficientsDirty()) {
+        double value1 = biquadProcessor()->parameter1()->smoothedValue();
+        double value2 = biquadProcessor()->parameter2()->smoothedValue();
+        
+        // Convert from Hertz to normalized frequency 0 -> 1.
+        double nyquist = this->nyquist();
+        double normalizedValue1 = value1 / nyquist;
+
+        // Configure the biquad with the new filter parameters for the appropriate type of filter.
+        switch (biquadProcessor()->type()) {
+        case BiquadProcessor::LowPass2:
+            m_biquad.setLowpassParams(normalizedValue1, value2);
+            break;
+
+        case BiquadProcessor::HighPass2:
+            m_biquad.setHighpassParams(normalizedValue1, value2);
+            break;
+
+        case BiquadProcessor::LowShelf:
+            m_biquad.setLowShelfParams(normalizedValue1, value2);
+            break;
+
+        // FIXME: add other biquad filter types...
+        case BiquadProcessor::Peaking:
+        case BiquadProcessor::Allpass:
+        case BiquadProcessor::HighShelf:
+            break;
+        }
+    }
+
+    m_biquad.process(source, destination, framesToProcess);
+}
+
+} // namespace WebCore
+
+#endif // ENABLE(WEB_AUDIO)
diff --git a/WebCore/webaudio/BiquadDSPKernel.h b/WebCore/webaudio/BiquadDSPKernel.h
new file mode 100644
index 0000000..47d0f34
--- /dev/null
+++ b/WebCore/webaudio/BiquadDSPKernel.h
@@ -0,0 +1,56 @@
+/*
+ * Copyright (C) 2010, Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1.  Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2.  Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef BiquadDSPKernel_h
+#define BiquadDSPKernel_h
+
+#include "AudioDSPKernel.h"
+#include "Biquad.h"
+#include "BiquadProcessor.h"
+
+namespace WebCore {
+
+class BiquadProcessor;
+
+// BiquadDSPKernel is an AudioDSPKernel and is responsible for filtering one channel of a BiquadProcessor using a Biquad object.
+
+class BiquadDSPKernel : public AudioDSPKernel {
+public:  
+    BiquadDSPKernel(BiquadProcessor* processor)
+    : AudioDSPKernel(processor)
+    {
+    }
+    
+    // AudioDSPKernel
+    virtual void process(const float* source, float* dest, size_t framesToProcess);
+    virtual void reset() { m_biquad.reset(); }
+    
+protected:
+    Biquad m_biquad;
+    BiquadProcessor* biquadProcessor() { return static_cast<BiquadProcessor*>(processor()); }
+};
+
+} // namespace WebCore
+
+#endif // BiquadDSPKernel_h

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list