[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
abarth at webkit.org
abarth at webkit.org
Wed Dec 22 14:36:50 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit aaf6e78ce53bb74921a255fb615b3f62d0c6c26a
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Oct 14 05:28:53 2010 +0000
2010-10-13 Adam Barth <abarth at webkit.org>
Unreviewed.
Chromium port can't run JavaScriptCore tests
https://bugs.webkit.org/show_bug.cgi?id=47654
This lets webkit-patch build-and-test work on Chromium.
* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/tool/steps/runtests.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index a2ec9ad..e26d12c 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,5 +1,17 @@
2010-10-13 Adam Barth <abarth at webkit.org>
+ Unreviewed.
+
+ Chromium port can't run JavaScriptCore tests
+ https://bugs.webkit.org/show_bug.cgi?id=47654
+
+ This lets webkit-patch build-and-test work on Chromium.
+
+ * Scripts/webkitpy/common/config/ports.py:
+ * Scripts/webkitpy/tool/steps/runtests.py:
+
+2010-10-13 Adam Barth <abarth at webkit.org>
+
Reviewed by Eric Seidel.
Make --port a global option and pass the port information to the commit-queue subprocess
diff --git a/WebKitTools/Scripts/webkitpy/common/config/ports.py b/WebKitTools/Scripts/webkitpy/common/config/ports.py
index d9b9c43..5a85f7d 100644
--- a/WebKitTools/Scripts/webkitpy/common/config/ports.py
+++ b/WebKitTools/Scripts/webkitpy/common/config/ports.py
@@ -228,6 +228,10 @@ class ChromiumPort(WebKitPort):
"--no-pixel-tests",
]
+ @classmethod
+ def run_javascriptcore_tests_command(cls):
+ return None
+
class ChromiumXVFBPort(ChromiumPort):
diff --git a/WebKitTools/Scripts/webkitpy/tool/steps/runtests.py b/WebKitTools/Scripts/webkitpy/tool/steps/runtests.py
index 89ef694..6fc94a1 100644
--- a/WebKitTools/Scripts/webkitpy/tool/steps/runtests.py
+++ b/WebKitTools/Scripts/webkitpy/tool/steps/runtests.py
@@ -48,8 +48,11 @@ class RunTests(AbstractStep):
self._tool.executive.run_and_throw_if_fail(self.port().run_python_unittests_command())
log("Running Perl unit tests")
self._tool.executive.run_and_throw_if_fail(self.port().run_perl_unittests_command())
- log("Running JavaScriptCore tests")
- self._tool.executive.run_and_throw_if_fail(self.port().run_javascriptcore_tests_command(), quiet=True)
+
+ javascriptcore_tests_command = self.port().run_javascriptcore_tests_command()
+ if javascriptcore_tests_command:
+ log("Running JavaScriptCore tests")
+ self._tool.executive.run_and_throw_if_fail(javascriptcore_tests_command, quiet=True)
log("Running run-webkit-tests")
args = self.port().run_webkit_tests_command()
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list