[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
inferno at chromium.org
inferno at chromium.org
Wed Dec 22 14:58:24 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 2316c83c9425f6300e861096220be675001a662d
Author: inferno at chromium.org <inferno at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Oct 26 18:55:10 2010 +0000
2010-10-26 Abhishek Arya <inferno at chromium.org>
Reviewed by Dimitri Glazkov.
Added checks to ensure that events types are right before casting.
https://bugs.webkit.org/show_bug.cgi?id=48345
* html/ImageDocument.cpp:
(WebCore::ImageEventListener::handleEvent):
* inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::handleEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index aa3447c..ea93a22 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2010-10-26 Abhishek Arya <inferno at chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Added checks to ensure that events types are right before casting.
+ https://bugs.webkit.org/show_bug.cgi?id=48345
+
+ * html/ImageDocument.cpp:
+ (WebCore::ImageEventListener::handleEvent):
+ * inspector/InspectorDOMStorageResource.cpp:
+ (WebCore::InspectorDOMStorageResource::handleEvent):
+
2010-10-26 Dai Mikurube <dmikurube at google.com>
Reviewed by Kent Tamura.
diff --git a/WebCore/html/ImageDocument.cpp b/WebCore/html/ImageDocument.cpp
index 6361f43..a42ccc8 100644
--- a/WebCore/html/ImageDocument.cpp
+++ b/WebCore/html/ImageDocument.cpp
@@ -387,7 +387,7 @@ void ImageEventListener::handleEvent(ScriptExecutionContext*, Event* event)
{
if (event->type() == eventNames().resizeEvent)
m_doc->windowSizeChanged();
- else if (event->type() == eventNames().clickEvent) {
+ else if (event->type() == eventNames().clickEvent && event->isMouseEvent()) {
MouseEvent* mouseEvent = static_cast<MouseEvent*>(event);
m_doc->imageClicked(mouseEvent->x(), mouseEvent->y());
}
diff --git a/WebCore/inspector/InspectorDOMStorageResource.cpp b/WebCore/inspector/InspectorDOMStorageResource.cpp
index c8d76ba..cfd5f9f 100644
--- a/WebCore/inspector/InspectorDOMStorageResource.cpp
+++ b/WebCore/inspector/InspectorDOMStorageResource.cpp
@@ -100,7 +100,9 @@ void InspectorDOMStorageResource::startReportingChangesToFrontend()
void InspectorDOMStorageResource::handleEvent(ScriptExecutionContext*, Event* event)
{
ASSERT(m_frontend);
- ASSERT(eventNames().storageEvent == event->type());
+ if (event->type() != eventNames().storageEvent || !event->isStorageEvent())
+ return;
+
StorageEvent* storageEvent = static_cast<StorageEvent*>(event);
Storage* storage = storageEvent->storageArea();
ExceptionCode ec = 0;
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list