[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

jer.noble at apple.com jer.noble at apple.com
Wed Dec 22 15:16:34 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit a9f6ef536958ebedbcb2ceec9487dbf0fcfefd47
Author: jer.noble at apple.com <jer.noble at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Fri Oct 29 17:53:38 2010 +0000

    2010-10-27  Jer Noble  <jer.noble at apple.com>
    
            Reviewed by Darin Adler.
    
            Full screen video in Safari (still) exits full-screen if you switch to another
            app on a multi-display system.
            https://bugs.webkit.org/show_bug.cgi?id=47364
            <rdar://problem/8382299>
    
            The FullScreen window does not technically close when it deactivates, but the
            two NSWindows that make up the FullScreen feature should not hide when deactivated.
    
            * WebView/WebVideoFullscreenController.mm:
            (createBackgroundFullscreenWindow): Do not set hidesOnDeactivate.
            (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
            * WebView/WebVideoFullscreenHUDWindowController.mm:
            (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/mac/ChangeLog b/WebKit/mac/ChangeLog
index fdbf87f..fa4492e 100644
--- a/WebKit/mac/ChangeLog
+++ b/WebKit/mac/ChangeLog
@@ -1,3 +1,21 @@
+2010-10-27  Jer Noble  <jer.noble at apple.com>
+
+        Reviewed by Darin Adler.
+
+        Full screen video in Safari (still) exits full-screen if you switch to another 
+        app on a multi-display system.
+        https://bugs.webkit.org/show_bug.cgi?id=47364
+        <rdar://problem/8382299>
+        
+        The FullScreen window does not technically close when it deactivates, but the 
+        two NSWindows that make up the FullScreen feature should not hide when deactivated.
+        
+        * WebView/WebVideoFullscreenController.mm:
+        (createBackgroundFullscreenWindow): Do not set hidesOnDeactivate.
+        (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
+        * WebView/WebVideoFullscreenHUDWindowController.mm:
+        (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
+
 2010-10-29  Alexey Proskuryakov  <ap at apple.com>
 
         Reviewed by Darin Adler.
diff --git a/WebKit/mac/WebView/WebVideoFullscreenController.mm b/WebKit/mac/WebView/WebVideoFullscreenController.mm
index d3ec127..2687b14 100644
--- a/WebKit/mac/WebView/WebVideoFullscreenController.mm
+++ b/WebKit/mac/WebView/WebVideoFullscreenController.mm
@@ -246,7 +246,6 @@ static NSWindow *createBackgroundFullscreenWindow(NSRect frame, int level)
     [window setOpaque:YES];
     [window setBackgroundColor:[NSColor blackColor]];
     [window setLevel:level];
-    [window setHidesOnDeactivate:YES];
     [window setReleasedWhenClosed:NO];
     return window;
 }
@@ -475,7 +474,6 @@ static NSWindow *createBackgroundFullscreenWindow(NSRect frame, int level)
         return nil;
     [self setOpaque:NO];
     [self setBackgroundColor:[NSColor clearColor]];
-    [self setHidesOnDeactivate:YES];
     [self setIgnoresMouseEvents:NO];
     [self setAcceptsMouseMovedEvents:YES];
     return self;
diff --git a/WebKit/mac/WebView/WebVideoFullscreenHUDWindowController.mm b/WebKit/mac/WebView/WebVideoFullscreenHUDWindowController.mm
index 1aa501e..6907311 100644
--- a/WebKit/mac/WebView/WebVideoFullscreenHUDWindowController.mm
+++ b/WebKit/mac/WebView/WebVideoFullscreenHUDWindowController.mm
@@ -91,7 +91,6 @@ static inline CGFloat webkit_CGFloor(CGFloat value)
     [self setAcceptsMouseMovedEvents:YES];
     [self setIgnoresMouseEvents:NO];
     [self setMovableByWindowBackground:YES];
-    [self setHidesOnDeactivate:YES];
 
     return self;
 }

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list