[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
commit-queue at webkit.org
commit-queue at webkit.org
Wed Dec 22 15:25:13 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 98421b26b6e7de0ea9e5b70d87c703318fc0718e
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Wed Nov 3 01:20:46 2010 +0000
2010-11-02 Chris Guillory <chris.guillory at google.com>
Reviewed by Chris Fleizach.
Chromium: Propagate a document value changed notification on scroll.
https://bugs.webkit.org/show_bug.cgi?id=48817
* platform/chromium/accessibility/post-notification-ValueChanged-expected.txt:
* platform/chromium/accessibility/post-notification-ValueChanged.html:
2010-11-02 Chris Guillory <chris.guillory at google.com>
Reviewed by Chris Fleizach.
Chromium: Propagate a document value changed notification on scroll.
https://bugs.webkit.org/show_bug.cgi?id=48817
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isAccessibilityScrollbar):
* accessibility/AccessibilityScrollbar.h:
(WebCore::AccessibilityScrollbar::scrollbar):
(WebCore::AccessibilityScrollbar::isAccessibilityScrollbar):
* accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
2010-11-02 Chris Guillory <chris.guillory at google.com>
Reviewed by Chris Fleizach.
Chromium: Propagate a document value changed notification on scroll.
https://bugs.webkit.org/show_bug.cgi?id=48817
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::boundingBoxRect):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 1d7a86e..ccc3541 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,13 @@
+2010-11-02 Chris Guillory <chris.guillory at google.com>
+
+ Reviewed by Chris Fleizach.
+
+ Chromium: Propagate a document value changed notification on scroll.
+ https://bugs.webkit.org/show_bug.cgi?id=48817
+
+ * platform/chromium/accessibility/post-notification-ValueChanged-expected.txt:
+ * platform/chromium/accessibility/post-notification-ValueChanged.html:
+
2010-11-02 Dmitry Titov <dimich at chromium.org>
[Chromium] Unreviewed update of test expectations.
diff --git a/LayoutTests/platform/chromium/accessibility/post-notification-ValueChanged-expected.txt b/LayoutTests/platform/chromium/accessibility/post-notification-ValueChanged-expected.txt
index 8cebff2..4ea714a 100644
--- a/LayoutTests/platform/chromium/accessibility/post-notification-ValueChanged-expected.txt
+++ b/LayoutTests/platform/chromium/accessibility/post-notification-ValueChanged-expected.txt
@@ -1,3 +1,4 @@
+AccessibilityNotification - ValueChanged
AccessibilityNotification - ValueChanged - id:text-for-ValueChanged
AccessibilityNotification - LoadComplete
This tests that chromium correctly recieves the ValueChanged notification.
diff --git a/LayoutTests/platform/chromium/accessibility/post-notification-ValueChanged.html b/LayoutTests/platform/chromium/accessibility/post-notification-ValueChanged.html
index 59c25f9..c0d1891 100644
--- a/LayoutTests/platform/chromium/accessibility/post-notification-ValueChanged.html
+++ b/LayoutTests/platform/chromium/accessibility/post-notification-ValueChanged.html
@@ -2,11 +2,16 @@
<head>
<script>
function testNotification() {
- document.getElementById("text-for-ValueChanged").value = "button"
+ // Scroll the window which should generate an accessibility value changed
+ // notification for top document's vertical scrollbar.
+ if (window.eventSender)
+ window.eventSender.keyDown("pageDown");
+
+ document.getElementById("text-for-ValueChanged").value = "button";
}
</script>
</head>
-<body onload="test()">
+<body onload="test()" style="height:200%;">
This tests that chromium correctly recieves the ValueChanged notification.
<input id="text-for-ValueChanged" aria-help="text-for-ValueChanged" type="text" value="value" />
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 95bb336..0c9ff0b 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,18 @@
+2010-11-02 Chris Guillory <chris.guillory at google.com>
+
+ Reviewed by Chris Fleizach.
+
+ Chromium: Propagate a document value changed notification on scroll.
+ https://bugs.webkit.org/show_bug.cgi?id=48817
+
+ * accessibility/AccessibilityObject.h:
+ (WebCore::AccessibilityObject::isAccessibilityScrollbar):
+ * accessibility/AccessibilityScrollbar.h:
+ (WebCore::AccessibilityScrollbar::scrollbar):
+ (WebCore::AccessibilityScrollbar::isAccessibilityScrollbar):
+ * accessibility/chromium/AXObjectCacheChromium.cpp:
+ (WebCore::AXObjectCache::postPlatformNotification):
+
2010-11-02 Chris Rogers <crogers at google.com>
Reviewed by Kenneth Russell.
diff --git a/WebCore/accessibility/AccessibilityObject.h b/WebCore/accessibility/AccessibilityObject.h
index 66424ea..85f3e27 100644
--- a/WebCore/accessibility/AccessibilityObject.h
+++ b/WebCore/accessibility/AccessibilityObject.h
@@ -259,6 +259,7 @@ public:
typedef Vector<RefPtr<AccessibilityObject> > AccessibilityChildrenVector;
virtual bool isAccessibilityRenderObject() const { return false; }
+ virtual bool isAccessibilityScrollbar() const { return false; }
virtual bool isAnchor() const { return false; }
virtual bool isAttachment() const { return false; }
virtual bool isHeading() const { return false; }
diff --git a/WebCore/accessibility/AccessibilityScrollbar.h b/WebCore/accessibility/AccessibilityScrollbar.h
index d75e60c..9a8d978 100644
--- a/WebCore/accessibility/AccessibilityScrollbar.h
+++ b/WebCore/accessibility/AccessibilityScrollbar.h
@@ -41,6 +41,10 @@ public:
void setScrollbar(Scrollbar* scrollbar) { m_scrollbar = scrollbar; }
+ Scrollbar* scrollbar() const { return m_scrollbar; }
+
+ virtual bool isAccessibilityScrollbar() const { return true; }
+
virtual AccessibilityRole roleValue() const { return ScrollBarRole; }
virtual float valueForRange() const;
diff --git a/WebCore/accessibility/chromium/AXObjectCacheChromium.cpp b/WebCore/accessibility/chromium/AXObjectCacheChromium.cpp
index b02fe00..6d92cab 100644
--- a/WebCore/accessibility/chromium/AXObjectCacheChromium.cpp
+++ b/WebCore/accessibility/chromium/AXObjectCacheChromium.cpp
@@ -27,9 +27,11 @@
#include "config.h"
#include "AXObjectCache.h"
#include "AccessibilityObject.h"
+#include "AccessibilityScrollbar.h"
#include "Chrome.h"
#include "ChromeClient.h"
#include "FrameView.h"
+#include "Scrollbar.h"
namespace WebCore {
@@ -47,6 +49,17 @@ void AXObjectCache::attachWrapper(AccessibilityObject*)
void AXObjectCache::postPlatformNotification(AccessibilityObject* obj, AXNotification notification)
{
+ if (obj->isAccessibilityScrollbar() && notification == AXValueChanged) {
+ // Send document value changed on scrollbar value changed notification.
+ Scrollbar* scrollBar = static_cast<AccessibilityScrollbar*>(obj)->scrollbar();
+ if (!scrollBar || !scrollBar->parent() || !scrollBar->parent()->isFrameView())
+ return;
+ Document* document = static_cast<FrameView*>(scrollBar->parent())->frame()->document();
+ if (document != document->topDocument())
+ return;
+ obj = get(document->renderer());
+ }
+
if (!obj || !obj->document() || !obj->documentFrameView() || !obj->documentFrameView()->frame() || !obj->documentFrameView()->frame()->page())
return;
diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
index 087167a..40c4785 100644
--- a/WebKit/chromium/ChangeLog
+++ b/WebKit/chromium/ChangeLog
@@ -1,3 +1,13 @@
+2010-11-02 Chris Guillory <chris.guillory at google.com>
+
+ Reviewed by Chris Fleizach.
+
+ Chromium: Propagate a document value changed notification on scroll.
+ https://bugs.webkit.org/show_bug.cgi?id=48817
+
+ * src/WebAccessibilityObject.cpp:
+ (WebKit::WebAccessibilityObject::boundingBoxRect):
+
2010-10-29 John Abd-El-Malek <jam at chromium.org>
Reviewed by Darin Fisher.
diff --git a/WebKit/chromium/src/WebAccessibilityObject.cpp b/WebKit/chromium/src/WebAccessibilityObject.cpp
index 96a3173..9df69cf 100644
--- a/WebKit/chromium/src/WebAccessibilityObject.cpp
+++ b/WebKit/chromium/src/WebAccessibilityObject.cpp
@@ -351,7 +351,7 @@ WebRect WebAccessibilityObject::boundingBoxRect() const
return WebRect();
m_private->updateBackingStore();
- return m_private->documentFrameView()->contentsToWindow(m_private->boundingBoxRect());
+ return m_private->boundingBoxRect();
}
WebString WebAccessibilityObject::helpText() const
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list