[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

chang.shu at nokia.com chang.shu at nokia.com
Wed Dec 22 15:46:39 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 8802eb54af39dd1ab34972971c6b4a3d5b75ab03
Author: chang.shu at nokia.com <chang.shu at nokia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Fri Nov 12 04:16:12 2010 +0000

    2010-11-11  Chang Shu  <chang.shu at nokia.com>
    
            Reviewed by Antonio Gomes.
    
            [GTK] Unskip tests that are passing now.
            fast/events/spatial-navigation/snav-input.html
            fast/events/spatial-navigation/snav-textarea.html
            https://bugs.webkit.org/show_bug.cgi?id=49056
    
            * platform/gtk/Skipped:
    2010-11-11  Chang Shu  <chang.shu at nokia.com>
    
            Reviewed by Antonio Gomes.
    
            [GTK] Replace "MoveForward"/"MoveBackward" with "MoveRight"/"MoveLeft"
            to make spatial navigation work on input/textarea.
            https://bugs.webkit.org/show_bug.cgi?id=49056
    
            * WebCoreSupport/EditorClientGtk.cpp:
            (WebKit::moveCursorCallback):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index f5b3bdf..1c9adda 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,14 @@
+2010-11-11  Chang Shu  <chang.shu at nokia.com>
+
+        Reviewed by Antonio Gomes.
+
+        [GTK] Unskip tests that are passing now.
+        fast/events/spatial-navigation/snav-input.html
+        fast/events/spatial-navigation/snav-textarea.html
+        https://bugs.webkit.org/show_bug.cgi?id=49056
+
+        * platform/gtk/Skipped:
+
 2010-11-11  Julie-Jeongeun-Kim  <jiyuluna at gmail.com>
 
         Reviewed by Kent Tamura.
diff --git a/LayoutTests/platform/gtk/Skipped b/LayoutTests/platform/gtk/Skipped
index 23a6b04..ca01a5d 100644
--- a/LayoutTests/platform/gtk/Skipped
+++ b/LayoutTests/platform/gtk/Skipped
@@ -4964,11 +4964,6 @@ scrollbars/scrollbar-middleclick-nopaste.html
 # Relies on WebKit API [WebView _loadBackForwardListFromOtherView:]
 fast/loader/crash-copying-backforwardlist.html
 
-# Spatial Navigation
-# https://bugs.webkit.org/show_bug.cgi?id=49056
-fast/events/spatial-navigation/snav-input.html
-fast/events/spatial-navigation/snav-textarea.html
-
 # Implement LayoutTestController::callShouldCloseOnWebView()
 fast/events/onbeforeunload-focused-iframe.html
 
diff --git a/WebKit/gtk/ChangeLog b/WebKit/gtk/ChangeLog
index 6d9a652..580d23a 100644
--- a/WebKit/gtk/ChangeLog
+++ b/WebKit/gtk/ChangeLog
@@ -1,3 +1,14 @@
+2010-11-11  Chang Shu  <chang.shu at nokia.com>
+
+        Reviewed by Antonio Gomes.
+
+        [GTK] Replace "MoveForward"/"MoveBackward" with "MoveRight"/"MoveLeft"
+        to make spatial navigation work on input/textarea.
+        https://bugs.webkit.org/show_bug.cgi?id=49056
+
+        * WebCoreSupport/EditorClientGtk.cpp:
+        (WebKit::moveCursorCallback):
+
 2010-11-08  Nicolas Dufresne  <nicolas.dufresne at collabora.co.uk>
 
         Reviewed by Martin Robinson.
diff --git a/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp b/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp
index 749efe9..c7b30b1 100644
--- a/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp
+++ b/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp
@@ -213,6 +213,13 @@ static void moveCursorCallback(GtkWidget* widget, GtkMovementStep step, gint cou
     if (!rawCommand)
         return;
 
+    if (isSpatialNavigationEnabled(core(client->webView())->focusController()->focusedOrMainFrame()) && step == 1) {
+        if (direction == 1)
+            rawCommand = "MoveRight";
+        else if (!direction)
+            rawCommand = "MoveLeft";
+    }
+
     for (int i = 0; i < abs(count); i++)
         client->addPendingEditorCommand(rawCommand);
 }

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list