[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

commit-queue at webkit.org commit-queue at webkit.org
Wed Dec 22 16:15:46 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 91d38a7effcf9e3d668de80793e3a494a2a06b71
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Sat Nov 20 06:27:25 2010 +0000

    2010-11-19  Zalan Bujtas  <zbujtas at gmail.com>
    
            Reviewed by Andreas Kling.
    
            WebUIClient::createNewPage() expects a retained WKPageRef.
            https://bugs.webkit.org/show_bug.cgi?id=48549
    
            * UIProcess/API/qt/ClientImpl.cpp:
            (qt_wk_createNewPage):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit2/ChangeLog b/WebKit2/ChangeLog
index 417dc44..ba6b3bf 100644
--- a/WebKit2/ChangeLog
+++ b/WebKit2/ChangeLog
@@ -1,3 +1,13 @@
+2010-11-19  Zalan Bujtas  <zbujtas at gmail.com>
+
+        Reviewed by Andreas Kling.
+
+        WebUIClient::createNewPage() expects a retained WKPageRef. 
+        https://bugs.webkit.org/show_bug.cgi?id=48549
+
+        * UIProcess/API/qt/ClientImpl.cpp:
+        (qt_wk_createNewPage):
+
 2010-11-19  Anders Carlsson  <andersca at apple.com>
 
         Reviewed by Sam Weinig.
diff --git a/WebKit2/UIProcess/API/qt/ClientImpl.cpp b/WebKit2/UIProcess/API/qt/ClientImpl.cpp
index 5b60728..644f612 100644
--- a/WebKit2/UIProcess/API/qt/ClientImpl.cpp
+++ b/WebKit2/UIProcess/API/qt/ClientImpl.cpp
@@ -26,6 +26,7 @@
 #include <qwkpage.h>
 #include <qwkpage_p.h>
 #include <WKFrame.h>
+#include <WKType.h>
 
 using namespace WebKit;
 
@@ -143,8 +144,10 @@ WKPageRef qt_wk_createNewPage(WKPageRef page, WKDictionaryRef features, WKEventM
     if (!createNewPageFn)
         return 0;
 
-    if (QWKPage* newPage = createNewPageFn(wkPage))
+    if (QWKPage* newPage = createNewPageFn(wkPage)) {
+        WKRetain(newPage->pageRef());
         return newPage->pageRef();
+    }
 
     return 0;
 }

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list