[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

commit-queue at webkit.org commit-queue at webkit.org
Wed Dec 22 16:26:55 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 7c30afb7ee38ec56cafa46e3cc1b60c0e6c1120e
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Nov 23 22:51:43 2010 +0000

    2010-11-23  Andreas Kling  <kling at webkit.org>
    
            Reviewed by Tor Arne Vestbø.
    
            [Qt] Selecting shadowed text causes rendering artifacts
            https://bugs.webkit.org/show_bug.cgi?id=49990
    
            When selecting text starting from the end of a word, we need to use
            the X coordinate of the start of the substring when calculating the
            bounding rect for a ContextShadow.
    
            * platform/graphics/qt/FontQt.cpp:
            (WebCore::drawTextCommon):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 4592c5a..c51d168 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2010-11-23  Andreas Kling  <kling at webkit.org>
+
+        Reviewed by Tor Arne Vestbø.
+
+        [Qt] Selecting shadowed text causes rendering artifacts
+        https://bugs.webkit.org/show_bug.cgi?id=49990
+
+        When selecting text starting from the end of a word, we need to use
+        the X coordinate of the start of the substring when calculating the
+        bounding rect for a ContextShadow.
+
+        * platform/graphics/qt/FontQt.cpp:
+        (WebCore::drawTextCommon):
+
 2010-11-23  Chris Guillory  <chris.guillory at google.com>
 
         Reviewed by Dimitri Glazkov.
diff --git a/WebCore/platform/graphics/qt/FontQt.cpp b/WebCore/platform/graphics/qt/FontQt.cpp
index c0acc7c..356edfa 100644
--- a/WebCore/platform/graphics/qt/FontQt.cpp
+++ b/WebCore/platform/graphics/qt/FontQt.cpp
@@ -198,7 +198,7 @@ static void drawTextCommon(GraphicsContext* ctx, const TextRun& run, const Float
                 p->restore();
             } else {
                 QFontMetrics fm(font);
-                QRectF boundingRect(point.x(), point.y() - fm.ascent(), fm.width(string), fm.height());
+                QRectF boundingRect(pt.x(), point.y() - fm.ascent(), fm.width(string), fm.height());
                 QPainter* shadowPainter = ctxShadow->beginShadowLayer(p, boundingRect);
                 if (shadowPainter) {
                     // Since it will be blurred anyway, we don't care about render hints.
@@ -215,7 +215,7 @@ static void drawTextCommon(GraphicsContext* ctx, const TextRun& run, const Float
                 p->translate(-ctxShadow->offset());
             } else {
                 QFontMetrics fm(font);
-                QRectF boundingRect(point.x(), point.y() - fm.ascent(), fm.width(string), fm.height());
+                QRectF boundingRect(pt.x(), point.y() - fm.ascent(), fm.width(string), fm.height());
                 QPainter* shadowPainter = ctxShadow->beginShadowLayer(p, boundingRect);
                 if (shadowPainter) {
                     // Since it will be blurred anyway, we don't care about render hints.

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list