[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-10851-g50815da
mitz at apple.com
mitz at apple.com
Wed Dec 22 17:51:20 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 75ecd1b5f054cb23143cc4510b14173c0bcfe98c
Author: mitz at apple.com <mitz at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Wed Dec 1 18:36:44 2010 +0000
WebKitTestRunner needs layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50238
Reviewed by Darin Adler.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index 749b423..7e3b475 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,15 @@
+2010-12-01 Dan Bernstein <mitz at apple.com>
+
+ Reviewed by Darin Adler.
+
+ WebKitTestRunner needs layoutTestController.findString
+ https://bugs.webkit.org/show_bug.cgi?id=50238
+
+ * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
+ * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
+ (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
+ * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
+
2010-12-01 Steve Falkenburg <sfalken at apple.com>
Try using svn:eol-style native on a vcproj file.
diff --git a/WebKitTools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl b/WebKitTools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl
index 583eb0a..acc2f47 100644
--- a/WebKitTools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl
+++ b/WebKitTools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl
@@ -73,6 +73,9 @@ module WTR {
// Compositing testing.
DOMString layerTreeAsText();
+
+ // Text search testing.
+ boolean findString(in DOMString target, in object optionsArray);
};
}
diff --git a/WebKitTools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp b/WebKitTools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp
index 2285d42..78b2ae9 100644
--- a/WebKitTools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp
+++ b/WebKitTools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp
@@ -233,11 +233,14 @@ void LayoutTestController::execCommand(JSStringRef name, JSStringRef argument)
WKBundlePageExecuteEditingCommand(InjectedBundle::shared().page()->page(), toWK(name).get(), toWK(argument).get());
}
-bool LayoutTestController::findString(JSContextRef context, JSStringRef target, JSObjectRef optionsArray)
+bool LayoutTestController::findString(JSStringRef target, JSValueRef optionsArrayAsValue)
{
WKFindOptions options = 0;
+ WKBundleFrameRef mainFrame = WKBundlePageGetMainFrame(InjectedBundle::shared().page()->page());
+ JSContextRef context = WKBundleFrameGetJavaScriptContext(mainFrame);
JSRetainPtr<JSStringRef> lengthPropertyName(Adopt, JSStringCreateWithUTF8CString("length"));
+ JSObjectRef optionsArray = JSValueToObject(context, optionsArrayAsValue, 0);
JSValueRef lengthValue = JSObjectGetProperty(context, optionsArray, lengthPropertyName.get(), 0);
if (!JSValueIsNumber(context, lengthValue))
return false;
diff --git a/WebKitTools/WebKitTestRunner/InjectedBundle/LayoutTestController.h b/WebKitTools/WebKitTestRunner/InjectedBundle/LayoutTestController.h
index f4921a9..2aaad08 100644
--- a/WebKitTools/WebKitTestRunner/InjectedBundle/LayoutTestController.h
+++ b/WebKitTools/WebKitTestRunner/InjectedBundle/LayoutTestController.h
@@ -102,7 +102,7 @@ public:
void addUserStyleSheet(JSStringRef source, bool allFrames);
// Text search testing.
- bool findString(JSContextRef, JSStringRef, JSObjectRef optionsArray);
+ bool findString(JSStringRef, JSValueRef optionsArray);
enum WhatToDump { RenderTree, MainFrameText, AllFramesText };
WhatToDump whatToDump() const { return m_whatToDump; }
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list