[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-10851-g50815da

mrowe at apple.com mrowe at apple.com
Wed Dec 22 17:56:27 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 37a163d117487d48c56f2c56ab396935d150bc93
Author: mrowe at apple.com <mrowe at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Fri Dec 3 00:30:17 2010 +0000

    <rdar://problem/8708730> Objects reported as being leaked due to lack of autorelease pool
    
    Reviewed by Beth Dakin.
    
    * Misc/WebNSFileManagerExtras.m:
    (setMetaData): Create an autorelease pool for the duration of the thread body.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/mac/ChangeLog b/WebKit/mac/ChangeLog
index edc0e61..764fbfe 100644
--- a/WebKit/mac/ChangeLog
+++ b/WebKit/mac/ChangeLog
@@ -1,3 +1,12 @@
+2010-12-02  Mark Rowe  <mrowe at apple.com>
+
+        Reviewed by Beth Dakin.
+
+        <rdar://problem/8708730> Objects reported as being leaked due to lack of autorelease pool
+
+        * Misc/WebNSFileManagerExtras.m:
+        (setMetaData): Create an autorelease pool for the duration of the thread body.
+
 2010-12-02  John Knottenbelt  <jknotten at chromium.org>
 
         Reviewed by Steve Block.
diff --git a/WebKit/mac/Misc/WebNSFileManagerExtras.m b/WebKit/mac/Misc/WebNSFileManagerExtras.m
index ad48fb8..cafb69d 100644
--- a/WebKit/mac/Misc/WebNSFileManagerExtras.m
+++ b/WebKit/mac/Misc/WebNSFileManagerExtras.m
@@ -94,6 +94,7 @@ typedef struct MetaDataInfo
 static void *setMetaData(void* context)
 {
     MetaDataInfo *info = (MetaDataInfo *)context;
+    NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];
     WKSetMetadataURL((NSString *)info->URLString, (NSString *)info->referrer, (NSString *)info->path);
 
     if (info->URLString)
@@ -102,8 +103,10 @@ static void *setMetaData(void* context)
         CFRelease(info->referrer);
     if (info->path)
         CFRelease(info->path);
-    
+
     free(info);
+    [pool drain];
+
     return 0;
 }
 

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list