[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-10851-g50815da

Wed Dec 22 18:03:05 UTC 2010

The following commit has been merged in the debian/experimental branch:
commit e3dfceba38d9f9ef81db6c9ddc10fca124b0105e
Author: cfleizach at apple.com <cfleizach at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Dec 6 17:36:01 2010 +0000

    AX does not support HTML5 "required"
    https://bugs.webkit.org/show_bug.cgi?id=50507
    
    Reviewed by Oliver Hunt.
    
    WebCore:
    
    Test: platform/mac/accessibility/html5-required-attribute.html
    
    * accessibility/AccessibilityRenderObject.cpp:
    (WebCore::AccessibilityRenderObject::isRequired):
    
    LayoutTests:
    
    * platform/mac/accessibility/html5-required-attribute-expected.txt: Added.
    * platform/mac/accessibility/html5-required-attribute.html: Added.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index ab865a8..a96b24f 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,13 @@
+2010-12-06  Chris Fleizach  <cfleizach at apple.com>
+
+        Reviewed by Oliver Hunt.
+
+        AX does not support HTML5 "required"
+        https://bugs.webkit.org/show_bug.cgi?id=50507
+
+        * platform/mac/accessibility/html5-required-attribute-expected.txt: Added.
+        * platform/mac/accessibility/html5-required-attribute.html: Added.
+
 2010-12-06  Victor Wang  <victorw at chromium.org>
 
         Unreviewed.
diff --git a/LayoutTests/platform/mac/accessibility/html5-required-attribute-expected.txt b/LayoutTests/platform/mac/accessibility/html5-required-attribute-expected.txt
new file mode 100644
index 0000000..e968512
--- /dev/null
+++ b/LayoutTests/platform/mac/accessibility/html5-required-attribute-expected.txt
@@ -0,0 +1,12 @@
+
+This tests that the required attribute is returned correctly through accessibility.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS accessibilityController.focusedElement.isRequired is true
+PASS accessibilityController.focusedElement.isRequired is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
diff --git a/LayoutTests/platform/mac/accessibility/html5-required-attribute.html b/LayoutTests/platform/mac/accessibility/html5-required-attribute.html
new file mode 100644
index 0000000..590379c
--- /dev/null
+++ b/LayoutTests/platform/mac/accessibility/html5-required-attribute.html
@@ -0,0 +1,37 @@
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<link rel="stylesheet" href="../../../fast/js/resources/js-test-style.css">
+<script>
+var successfullyParsed = false;
+</script>
+<script src="../../../fast/js/resources/js-test-pre.js"></script>
+</head>
+<body id="body">
+
+
+<input type="text" id="text1" required>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+    description("This tests that the required attribute is returned correctly through accessibility.");
+
+    if (window.accessibilityController) {
+
+        document.getElementById("text1").focus();
+        shouldBeTrue("accessibilityController.focusedElement.isRequired");
+
+        document.getElementById("text1").removeAttribute("required");
+        shouldBeFalse("accessibilityController.focusedElement.isRequired");
+
+    }
+
+    successfullyParsed = true;
+</script>
+
+<script src="../../../fast/js/resources/js-test-post.js"></script>
+</body>
+</html>
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 80e18c8..c0caea0 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2010-12-06  Chris Fleizach  <cfleizach at apple.com>
+
+        Reviewed by Oliver Hunt.
+
+        AX does not support HTML5 "required"
+        https://bugs.webkit.org/show_bug.cgi?id=50507
+
+        Test: platform/mac/accessibility/html5-required-attribute.html
+
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::isRequired):
+
 2010-12-06  Alejandro G. Castro  <alex at igalia.com>
 
         Reviewed by Martin Robinson.
diff --git a/WebCore/accessibility/AccessibilityRenderObject.cpp b/WebCore/accessibility/AccessibilityRenderObject.cpp
index 3c6079b..b860e07 100644
--- a/WebCore/accessibility/AccessibilityRenderObject.cpp
+++ b/WebCore/accessibility/AccessibilityRenderObject.cpp
@@ -2098,6 +2098,10 @@ bool AccessibilityRenderObject::isRequired() const
     if (equalIgnoringCase(getAttribute(aria_requiredAttr), "true"))
         return true;
     
+    Node* n = node();
+    if (n && (n->isElementNode() && static_cast<Element*>(n)->isFormControlElement()))
+        return static_cast<HTMLFormControlElement*>(n)->required();
+    
     return false;
 }
 

-- 
WebKit Debian packaging

