[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-10851-g50815da
weinig at apple.com
weinig at apple.com
Wed Dec 22 18:14:53 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 2cabd2a2a52e0c7b3664218899a45f860fe17454
Author: weinig at apple.com <weinig at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Dec 9 02:20:02 2010 +0000
Add WebKit2 Preference for TabsToLinks behavior.
<rdar://problem/8664263>
Reviewed by Gavin Barraclough.
* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetTabsToLinks):
(WKPreferencesGetTabsToLinks):
* UIProcess/API/C/WKPreferences.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::tabsToLinks):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::updatePreferences):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::tabsToLinks):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKit2/ChangeLog b/WebKit2/ChangeLog
index 7da350c..0875cb7 100644
--- a/WebKit2/ChangeLog
+++ b/WebKit2/ChangeLog
@@ -1,3 +1,23 @@
+2010-12-08 Sam Weinig <sam at webkit.org>
+
+ Reviewed by Gavin Barraclough.
+
+ Add WebKit2 Preference for TabsToLinks behavior.
+ <rdar://problem/8664263>
+
+ * Shared/WebPreferencesStore.h:
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetTabsToLinks):
+ (WKPreferencesGetTabsToLinks):
+ * UIProcess/API/C/WKPreferences.h:
+ * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+ (WebKit::WebChromeClient::tabsToLinks):
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::WebPage):
+ (WebKit::WebPage::updatePreferences):
+ * WebProcess/WebPage/WebPage.h:
+ (WebKit::WebPage::tabsToLinks):
+
2010-12-08 Benjamin Poulain <benjamin.poulain at nokia.com>
Reviewed by Andreas Kling.
diff --git a/WebKit2/Shared/WebPreferencesStore.h b/WebKit2/Shared/WebPreferencesStore.h
index 0b2973b..6f4e8f2 100644
--- a/WebKit2/Shared/WebPreferencesStore.h
+++ b/WebKit2/Shared/WebPreferencesStore.h
@@ -56,6 +56,7 @@ namespace WebKit {
macro(CompositingBordersVisible, compositingBordersVisible, Bool, bool, false) \
macro(CompositingRepaintCountersVisible, compositingRepaintCountersVisible, Bool, bool, false) \
macro(ForceFTPDirectoryListings, forceFTPDirectoryListings, Bool, bool, false) \
+ macro(TabsToLinks, tabsToLinks, Bool, bool, false) \
\
#define FOR_EACH_WEBKIT_UINT32_PREFERENCE(macro) \
diff --git a/WebKit2/UIProcess/API/C/WKPreferences.cpp b/WebKit2/UIProcess/API/C/WKPreferences.cpp
index 4b1a2fe..0de3083 100644
--- a/WebKit2/UIProcess/API/C/WKPreferences.cpp
+++ b/WebKit2/UIProcess/API/C/WKPreferences.cpp
@@ -359,3 +359,13 @@ WKStringRef WKPreferencesCopyFTPDirectoryTemplatePath(WKPreferencesRef preferenc
{
return toCopiedAPI(toImpl(preferencesRef)->ftpDirectoryTemplatePath());
}
+
+void WKPreferencesSetTabsToLinks(WKPreferencesRef preferencesRef, bool tabsToLinks)
+{
+ toImpl(preferencesRef)->setTabsToLinks(tabsToLinks);
+}
+
+bool WKPreferencesGetTabsToLinks(WKPreferencesRef preferencesRef)
+{
+ return toImpl(preferencesRef)->tabsToLinks();
+}
diff --git a/WebKit2/UIProcess/API/C/WKPreferences.h b/WebKit2/UIProcess/API/C/WKPreferences.h
index 47c9156..ed455f8 100644
--- a/WebKit2/UIProcess/API/C/WKPreferences.h
+++ b/WebKit2/UIProcess/API/C/WKPreferences.h
@@ -130,6 +130,10 @@ WK_EXPORT bool WKPreferencesGetDeveloperExtrasEnabled(WKPreferencesRef preferenc
WK_EXPORT void WKPreferencesSetTextAreasAreResizable(WKPreferencesRef preferencesRef, bool resizable);
WK_EXPORT bool WKPreferencesGetTextAreasAreResizable(WKPreferencesRef preferencesRef);
+// Defaults to false.
+WK_EXPORT void WKPreferencesSetTabsToLinks(WKPreferencesRef preferences, bool tabsToLinks);
+WK_EXPORT bool WKPreferencesGetTabsToLinks(WKPreferencesRef preferences);
+
#ifdef __cplusplus
}
#endif
diff --git a/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp b/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
index 2d5e4e0..011c8e5 100644
--- a/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
+++ b/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
@@ -310,8 +310,7 @@ bool WebChromeClient::shouldInterruptJavaScript()
bool WebChromeClient::tabsToLinks() const
{
- notImplemented();
- return false;
+ return m_page->tabsToLinks();
}
IntRect WebChromeClient::windowResizerRect() const
diff --git a/WebKit2/WebProcess/WebPage/WebPage.cpp b/WebKit2/WebProcess/WebPage/WebPage.cpp
index e1b17a2..01f4033 100644
--- a/WebKit2/WebProcess/WebPage/WebPage.cpp
+++ b/WebKit2/WebProcess/WebPage/WebPage.cpp
@@ -113,6 +113,7 @@ WebPage::WebPage(uint64_t pageID, const WebPageCreationParameters& parameters)
: m_viewSize(parameters.viewSize)
, m_isInRedo(false)
, m_isClosed(false)
+ , m_tabToLinks(false)
#if PLATFORM(MAC)
, m_windowIsVisible(false)
#elif PLATFORM(WIN)
@@ -876,7 +877,9 @@ void WebPage::preferencesDidChange(const WebPreferencesStore& store)
void WebPage::updatePreferences(const WebPreferencesStore& store)
{
Settings* settings = m_page->settings();
-
+
+ m_tabToLinks = store.getBoolValueForKey(WebPreferencesKey::tabsToLinksKey());
+
// FIXME: This should be generated from macro expansion for all preferences,
// but we currently don't match the naming of WebCore exactly so we are
// handrolling the boolean and integer preferences until that is fixed.
diff --git a/WebKit2/WebProcess/WebPage/WebPage.h b/WebKit2/WebProcess/WebPage/WebPage.h
index 6c9495a..0dab818 100644
--- a/WebKit2/WebProcess/WebPage/WebPage.h
+++ b/WebKit2/WebProcess/WebPage/WebPage.h
@@ -128,6 +128,7 @@ public:
void show();
String userAgent() const;
WebCore::IntRect windowResizerRect() const;
+ bool tabsToLinks() const { return m_tabToLinks; }
WebEditCommand* webEditCommand(uint64_t);
void addWebEditCommand(uint64_t, WebEditCommand*);
@@ -324,6 +325,8 @@ private:
bool m_isInRedo;
bool m_isClosed;
+ bool m_tabToLinks;
+
#if PLATFORM(MAC)
// Whether the containing window is visible or not.
bool m_windowIsVisible;
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list