[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-10851-g50815da

andersca at apple.com andersca at apple.com
Wed Dec 22 18:18:45 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 42ab217ce4d9b2000c35798af4c8b514463ed5fe
Author: andersca at apple.com <andersca at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Dec 9 19:17:42 2010 +0000

    Don't leak the PDFDocument
    https://bugs.webkit.org/show_bug.cgi?id=50771
    
    Reviewed by Sam Weinig.
    
    * UIProcess/API/mac/PDFViewController.mm:
    (WebKit::PDFViewController::setPDFDocumentData):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit2/ChangeLog b/WebKit2/ChangeLog
index 764d2ce..80b361d 100644
--- a/WebKit2/ChangeLog
+++ b/WebKit2/ChangeLog
@@ -2,6 +2,16 @@
 
         Reviewed by Sam Weinig.
 
+        Don't leak the PDFDocument
+        https://bugs.webkit.org/show_bug.cgi?id=50771
+
+        * UIProcess/API/mac/PDFViewController.mm:
+        (WebKit::PDFViewController::setPDFDocumentData):
+
+2010-12-09  Anders Carlsson  <andersca at apple.com>
+
+        Reviewed by Sam Weinig.
+
         Add a basic implementation of PDF support on Mac
         https://bugs.webkit.org/show_bug.cgi?id=50768
 
diff --git a/WebKit2/UIProcess/API/mac/PDFViewController.mm b/WebKit2/UIProcess/API/mac/PDFViewController.mm
index 07bb73e..476dc7b 100644
--- a/WebKit2/UIProcess/API/mac/PDFViewController.mm
+++ b/WebKit2/UIProcess/API/mac/PDFViewController.mm
@@ -143,8 +143,8 @@ void PDFViewController::setPDFDocumentData(const String& mimeType, const CoreIPC
         data.adoptCF(CFDataCreate(0, dataReference.data(), dataReference.size()));
     }
 
-    PDFDocument* pdfDocument = [[pdfDocumentClass() alloc] initWithData:(NSData *)data.get()];
-    [m_pdfView setDocument:pdfDocument];
+    RetainPtr<PDFDocument> pdfDocument(AdoptNS, [[pdfDocumentClass() alloc] initWithData:(NSData *)data.get()]);
+    [m_pdfView setDocument:pdfDocument.get()];
 }
 
 Class PDFViewController::pdfDocumentClass()

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list