[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-10851-g50815da

[mario at webkit.org]

The following commit has been merged in the debian/experimental branch:
commit 8e07cd4f0d1faa5d6978546b6f9ed3cfb4f00801
Author: mario at webkit.org <mario at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Fri Dec 10 16:50:33 2010 +0000

    2010-12-10  Mario Sanchez Prada  <msanchez at igalia.com>
    
            Reviewed by Martin Robinson.
    
            [GTK] AX: implement isEnabled in DRT
            https://bugs.webkit.org/show_bug.cgi?id=50814
    
            Unskip passing accessibility/aria-disabled.html test.
    
            * platform/gtk/Skipped: Unskip test.
    2010-12-10  Mario Sanchez Prada  <msanchez at igalia.com>
    
            Reviewed by Martin Robinson.
    
            [GTK] AX: implement isEnabled in DRT
            https://bugs.webkit.org/show_bug.cgi?id=50814
    
            Implement AccessibilityUIElement::isEnabled() for GTK.
    
            * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
            (checkElementState): New function to refactor common code.
            (AccessibilityUIElement::isEnabled): Implement this by checking
            the current state of the AtkObject.
            (AccessibilityUIElement::isSelected): Use the new
            checkElementState function.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index f036ecf..9015e30 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,14 @@
+2010-12-10  Mario Sanchez Prada  <msanchez at igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [GTK] AX: implement isEnabled in DRT
+        https://bugs.webkit.org/show_bug.cgi?id=50814
+
+        Unskip passing accessibility/aria-disabled.html test.
+
+        * platform/gtk/Skipped: Unskip test.
+
 2010-12-10  Csaba Osztrogonác  <ossy at webkit.org>
 
         Unreviewed. Remove platform specific expected files after r73720.
diff --git a/LayoutTests/platform/gtk/Skipped b/LayoutTests/platform/gtk/Skipped
index 7ff5ba1..bf9359c 100644
--- a/LayoutTests/platform/gtk/Skipped
+++ b/LayoutTests/platform/gtk/Skipped
@@ -56,7 +56,6 @@ http/tests/incremental/split-hex-entities.pl
 # An implementation of accessibilityController is required.
 #   Tests failing
 accessibility/aria-combobox.html
-accessibility/aria-disabled.html
 accessibility/ellipsis-text.html
 accessibility/aria-help.html
 accessibility/aria-hidden.html
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index e4fa143..d338df3 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,19 @@
+2010-12-10  Mario Sanchez Prada  <msanchez at igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [GTK] AX: implement isEnabled in DRT
+        https://bugs.webkit.org/show_bug.cgi?id=50814
+
+        Implement AccessibilityUIElement::isEnabled() for GTK.
+
+        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
+        (checkElementState): New function to refactor common code.
+        (AccessibilityUIElement::isEnabled): Implement this by checking
+        the current state of the AtkObject.
+        (AccessibilityUIElement::isSelected): Use the new
+        checkElementState function.
+
 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte at nokia.com>
 
         Reviewed by Kenneth Rohde Christiansen.
diff --git a/WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp b/WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp
index c4f39be..c195e77 100644
--- a/WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp
+++ b/WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp
@@ -371,12 +371,19 @@ JSStringRef AccessibilityUIElement::valueDescription()
     return JSStringCreateWithCharacters(0, 0);
 }
 
-bool AccessibilityUIElement::isEnabled()
+static bool checkElementState(PlatformUIElement element, AtkStateType stateType)
 {
-    // FIXME: implement
-    return false;
+    if (!ATK_IS_OBJECT(element))
+         return false;
+
+    PlatformRefPtr<AtkStateSet> stateSet = adoptPlatformRef(atk_object_ref_state_set(ATK_OBJECT(element)));
+    return atk_state_set_contains_state(stateSet.get(), stateType);
 }
 
+bool AccessibilityUIElement::isEnabled()
+{
+    return checkElementState(m_element, ATK_STATE_ENABLED);
+}
 
 int AccessibilityUIElement::insertionPointLineNumber()
 {
@@ -398,13 +405,7 @@ bool AccessibilityUIElement::isRequired() const
 
 bool AccessibilityUIElement::isSelected() const
 {
-    if (!ATK_IS_OBJECT(m_element))
-        return false;
-
-    PlatformRefPtr<AtkStateSet> stateSet = adoptPlatformRef(atk_object_ref_state_set(ATK_OBJECT(m_element)));
-    gboolean isSelected = atk_state_set_contains_state(stateSet.get(), ATK_STATE_SELECTED);
-
-    return isSelected;
+    return checkElementState(m_element, ATK_STATE_SELECTED);
 }
 
 int AccessibilityUIElement::hierarchicalLevel() const

-- 
WebKit Debian packaging