[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
abarth at webkit.org
abarth at webkit.org
Wed Dec 22 13:27:28 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 6592a9433135ab69d10fbd788426ccc17b8bf6d4
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Sep 16 01:52:14 2010 +0000
2010-09-15 Adam Barth <abarth at webkit.org>
Unreviewed.
Only show the review-in-context link if there are contextual comments.
* code-review.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/BugsSite/ChangeLog b/BugsSite/ChangeLog
index 0cd20db..5b95290 100644
--- a/BugsSite/ChangeLog
+++ b/BugsSite/ChangeLog
@@ -1,5 +1,13 @@
2010-09-15 Adam Barth <abarth at webkit.org>
+ Unreviewed.
+
+ Only show the review-in-context link if there are contextual comments.
+
+ * code-review.js:
+
+2010-09-15 Adam Barth <abarth at webkit.org>
+
Reviewed by Eric Seidel.
[reviewtool] Show the status bubbles on the toolbar
diff --git a/BugsSite/code-review.js b/BugsSite/code-review.js
index 67f204e..b37a6b1 100644
--- a/BugsSite/code-review.js
+++ b/BugsSite/code-review.js
@@ -455,7 +455,7 @@
if (comment != '')
comment += '\n\n';
comment += comments_in_context.join('\n\n');
- if (comment != '')
+ if (comments_in_context.length > 0)
comment = 'View in context: ' + window.location + '\n\n' + comment;
var review_form = $('#reviewform').contents();
review_form.find('#comment').val(comment);
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list