[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
tkent at chromium.org
tkent at chromium.org
Wed Dec 22 13:29:55 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 98e1178d2499bc1b7cede59f860c4cdc47b9f98f
Author: tkent at chromium.org <tkent at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri Sep 17 06:20:48 2010 +0000
2010-09-16 takano takumi <takano1 at asia.apple.com>
Reviewed by Kent Tamura.
https://bugs.webkit.org/show_bug.cgi?id=45020
Support "block-flow" and "writing-mode": interpret properties into RenderStyle
Fixed a regression in SVG test introduced by my previous change.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator EWritingMode):
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index bffaa02..e13807d 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2010-09-16 takano takumi <takano1 at asia.apple.com>
+
+ Reviewed by Kent Tamura.
+
+ https://bugs.webkit.org/show_bug.cgi?id=45020
+ Support "block-flow" and "writing-mode": interpret properties into RenderStyle
+
+ Fixed a regression in SVG test introduced by my previous change.
+
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::operator EWritingMode):
+ * css/SVGCSSParser.cpp:
+ (WebCore::CSSParser::parseSVGValue):
+
2010-09-16 Kenneth Russell <kbr at google.com>
Reviewed by James Robinson.
diff --git a/WebCore/css/CSSPrimitiveValueMappings.h b/WebCore/css/CSSPrimitiveValueMappings.h
index 2183c3c..a452733 100644
--- a/WebCore/css/CSSPrimitiveValueMappings.h
+++ b/WebCore/css/CSSPrimitiveValueMappings.h
@@ -2684,7 +2684,23 @@ template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EWritingMode e)
template<> inline CSSPrimitiveValue::operator EWritingMode() const
{
- return static_cast<EWritingMode>(m_value.ident - CSSValueLrTb);
+ switch (m_value.ident) {
+ case CSSValueLrTb:
+ return WM_LRTB;
+ case CSSValueLr:
+ return WM_LR;
+ case CSSValueRlTb:
+ return WM_RLTB;
+ case CSSValueRl:
+ return WM_RL;
+ case CSSValueTbRl:
+ return WM_TBRL;
+ case CSSValueTb:
+ return WM_TB;
+ default:
+ ASSERT_NOT_REACHED();
+ return WM_LRTB;
+ }
}
template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EVectorEffect e)
diff --git a/WebCore/css/SVGCSSParser.cpp b/WebCore/css/SVGCSSParser.cpp
index 535b273..3c42d40 100644
--- a/WebCore/css/SVGCSSParser.cpp
+++ b/WebCore/css/SVGCSSParser.cpp
@@ -232,7 +232,7 @@ bool CSSParser::parseSVGValue(int propId, bool important)
case CSSPropertyWritingMode:
// lr-tb | rl_tb | tb-rl | lr | rl | tb | inherit
- if (id >= CSSValueLrTb && id <= CSSValueTb)
+ if (id == CSSValueLrTb || id == CSSValueRlTb || id == CSSValueTbRl || id == CSSValueLr || id == CSSValueRl || id == CSSValueTb)
valid_primitive = true;
break;
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list