[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
fsamuel at chromium.org
fsamuel at chromium.org
Wed Dec 22 14:15:27 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 179df3b740afe565d7323b6e039f9e88fb3483d2
Author: fsamuel at chromium.org <fsamuel at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Oct 5 23:55:13 2010 +0000
2010-10-05 Fady Samuel <fsamuel at chromium.org>
Reviewed by Darin Adler.
REGRESSION (r65539): One pixel white gaps when scrolling Trac changeset pages
https://bugs.webkit.org/show_bug.cgi?id=45131
Added a layout test to check for paint rects that touch the border of an adjacent sell,
when border-collapse: separate is set for the table.
* fast/table/simple_paint.html:
Don't do rtl as it doesn't exercise some of the new paint code.
* fast/table/simple_paint_separate_borders-expected.checksum: Added.
* fast/table/simple_paint_separate_borders-expected.png: Added.
* fast/table/simple_paint_separate_borders-expected.txt: Added.
* fast/table/simple_paint_separate_borders.html: Added.
2010-10-05 Fady Samuel <fsamuel at chromium.org>
Reviewed by Darin Adler.
REGRESSION (r65539): One pixel white gaps when scrolling Trac changeset pages
https://bugs.webkit.org/show_bug.cgi?id=45131
When border-collapse: separate property is set on the table, paintObject
may skip repainting cells, if the dirty region only touches one row/col of pixels.
Test: fast/table/simple_paint_separate_borders.html
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintObject):
Don't subtract one from the right and bottom of the dirty paint rect.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 8a49a1d..92b7528 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,20 @@
+2010-10-05 Fady Samuel <fsamuel at chromium.org>
+
+ Reviewed by Darin Adler.
+
+ REGRESSION (r65539): One pixel white gaps when scrolling Trac changeset pages
+ https://bugs.webkit.org/show_bug.cgi?id=45131
+
+ Added a layout test to check for paint rects that touch the border of an adjacent sell,
+ when border-collapse: separate is set for the table.
+
+ * fast/table/simple_paint.html:
+ Don't do rtl as it doesn't exercise some of the new paint code.
+ * fast/table/simple_paint_separate_borders-expected.checksum: Added.
+ * fast/table/simple_paint_separate_borders-expected.png: Added.
+ * fast/table/simple_paint_separate_borders-expected.txt: Added.
+ * fast/table/simple_paint_separate_borders.html: Added.
+
2010-10-04 Ryosuke Niwa <rniwa at webkit.org>
Reviewed by Tony Chang.
diff --git a/LayoutTests/fast/table/simple_paint-expected.checksum b/LayoutTests/fast/table/simple_paint-expected.checksum
index 0e88c80..59e4a18 100644
--- a/LayoutTests/fast/table/simple_paint-expected.checksum
+++ b/LayoutTests/fast/table/simple_paint-expected.checksum
@@ -1 +1 @@
-58a97402f46fee222b81aecc51b9f92c
\ No newline at end of file
+6c6f52d4891de4b265db2c5c3a3f53d5
\ No newline at end of file
diff --git a/LayoutTests/fast/table/simple_paint-expected.png b/LayoutTests/fast/table/simple_paint-expected.png
index e9b4b6e..1e3e01d 100644
Binary files a/LayoutTests/fast/table/simple_paint-expected.png and b/LayoutTests/fast/table/simple_paint-expected.png differ
diff --git a/LayoutTests/fast/table/simple_paint.html b/LayoutTests/fast/table/simple_paint.html
index 44ffe4c..75e5bd4 100644
--- a/LayoutTests/fast/table/simple_paint.html
+++ b/LayoutTests/fast/table/simple_paint.html
@@ -1,18 +1,27 @@
<html>
<head>
<title>Simple Table Painting</title>
- <style>
- table.testtable { border: 1px solid black; border-collapse:collapse; background-color: green; }
- table.testtable td { border: 1px solid black; font-size: 20px; background-color: green; width:60px; height:60px; direction:rtl;}
- body { margin: 0px 0px 0px 0px; }
- </style>
- <script>
- if (window.layoutTestController) {
- window.layoutTestController.waitUntilDone();
- }
- </script>
+ <style>
+ table.testtable { border: 1px solid black; border-collapse:collapse; background-color: green; }
+ table.testtable td { border: 1px solid black; font-size: 20px; background-color: green; width:60px; height:60px; direction:rtl;}
+ body { margin: 0px; }
+ </style>
+ <script>
+ if (window.layoutTestController) {
+ window.layoutTestController.waitUntilDone();
+ }
+ function repaintTest() {
+ var testCell = document.getElementById("testcell");
+ var offset = document.body.offsetTop;
+ testCell.style.backgroundColor = "green";
+ if (window.layoutTestController) {
+ window.layoutTestController.notifyDone();
+ }
+ }
+ </script>
+ <script type="text/javascript" src="../repaint/resources/repaint.js"></script>
</head>
- <body>
+ <body onload="runRepaintTest()">
<table class="testtable">
<tr>
<td></td>
@@ -51,12 +60,7 @@
</tr>
</table>
<script>
- var testCell = document.getElementById("testcell");
- var offset = document.body.offsetTop;
- testCell.style.backgroundColor = "green";
- if (window.layoutTestController) {
- window.layoutTestController.notifyDone();
- }
+
</script>
</body>
</html>
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 8897a41..1fde569 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,19 @@
+2010-10-05 Fady Samuel <fsamuel at chromium.org>
+
+ Reviewed by Darin Adler.
+
+ REGRESSION (r65539): One pixel white gaps when scrolling Trac changeset pages
+ https://bugs.webkit.org/show_bug.cgi?id=45131
+
+ When border-collapse: separate property is set on the table, paintObject
+ may skip repainting cells, if the dirty region only touches one row/col of pixels.
+
+ Test: fast/table/simple_paint_separate_borders.html
+
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::paintObject):
+ Don't subtract one from the right and bottom of the dirty paint rect.
+
2010-10-05 Sanjeev Radhakrishnan <sanjeevr at chromium.org>
Reviewed by Darin Fisher.
diff --git a/WebCore/rendering/RenderTableSection.cpp b/WebCore/rendering/RenderTableSection.cpp
index 7c4d0c4..ed4f527 100644
--- a/WebCore/rendering/RenderTableSection.cpp
+++ b/WebCore/rendering/RenderTableSection.cpp
@@ -1032,9 +1032,9 @@ void RenderTableSection::paintObject(PaintInfo& paintInfo, int tx, int ty)
if (startrow == m_rowPos.size() || (startrow > 0 && (m_rowPos[startrow] > top)))
--startrow;
- int bottom = relativeY + h + os - 1;
+ int bottom = relativeY + h + os;
endrow = std::lower_bound(m_rowPos.begin(), m_rowPos.end(), bottom) - m_rowPos.begin();
- if ((endrow == m_rowPos.size()) || (endrow > 0 && m_rowPos[endrow - 1] == bottom))
+ if (endrow == m_rowPos.size())
--endrow;
if (!endrow && ty + m_rowPos[0] - table()->outerBorderTop() <= y + h + os)
@@ -1051,9 +1051,9 @@ void RenderTableSection::paintObject(PaintInfo& paintInfo, int tx, int ty)
if ((startcol == columnPos.size()) || (startcol > 0 && (columnPos[startcol] > left)))
--startcol;
- int right = relativeX + w + os - 1;
+ int right = relativeX + w + os;
endcol = std::lower_bound(columnPos.begin(), columnPos.end(), right) - columnPos.begin();
- if (endcol == columnPos.size() || (endcol > 0 && (columnPos[endcol - 1] == right)))
+ if (endcol == columnPos.size())
--endcol;
if (!endcol && tx + table()->columnPositions()[0] - table()->outerBorderLeft() <= y + w + os)
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list