[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
chang.shu at nokia.com
chang.shu at nokia.com
Wed Dec 22 14:56:31 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 2ffbd60a16ccf0c706b0a28a4600e5ea60890175
Author: chang.shu at nokia.com <chang.shu at nokia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Mon Oct 25 20:04:20 2010 +0000
2010-10-25 Chang Shu <chang.shu at nokia.com>
Reviewed by Antonio Gomes.
Should use eventSender for simulating keyboard events instead of using js
event.initKeyboardEvent. Otherwise, inside WebCore, the keyboardevent
object does not have a "PlatformKeyboardEvent" associated with it and this
results different behavior as the real key press.
This code change unveils that test snav-multiple-select.html is broken. It
alos causes snav-single-select.html hangs on Mac. These will be fixed in
seperate patches.
https://bugs.webkit.org/show_bug.cgi?id=48134
* fast/events/spatial-navigation/resources/spatial-navigation-utils.js:
(doMove):
* fast/events/spatial-navigation/snav-multiple-select-expected.txt:
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index be74c3d..bc7bc34 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,21 @@
+2010-10-25 Chang Shu <chang.shu at nokia.com>
+
+ Reviewed by Antonio Gomes.
+
+ Should use eventSender for simulating keyboard events instead of using js
+ event.initKeyboardEvent. Otherwise, inside WebCore, the keyboardevent
+ object does not have a "PlatformKeyboardEvent" associated with it and this
+ results different behavior as the real key press.
+ This code change unveils that test snav-multiple-select.html is broken. It
+ alos causes snav-single-select.html hangs on Mac. These will be fixed in
+ seperate patches.
+ https://bugs.webkit.org/show_bug.cgi?id=48134
+
+ * fast/events/spatial-navigation/resources/spatial-navigation-utils.js:
+ (doMove):
+ * fast/events/spatial-navigation/snav-multiple-select-expected.txt:
+ * platform/mac/Skipped:
+
2010-10-25 Mihai Parparita <mihaip at chromium.org>
Unreviewed checksum rebaseline for Snow Leopard.
diff --git a/LayoutTests/fast/events/spatial-navigation/resources/spatial-navigation-utils.js b/LayoutTests/fast/events/spatial-navigation/resources/spatial-navigation-utils.js
index 56ac636..5dc750c 100644
--- a/LayoutTests/fast/events/spatial-navigation/resources/spatial-navigation-utils.js
+++ b/LayoutTests/fast/events/spatial-navigation/resources/spatial-navigation-utils.js
@@ -38,9 +38,27 @@ function prepareMove()
function doMove()
{
- var event = document.createEvent('KeyboardEvents');
- event.initKeyboardEvent('keydown', true, true, document.defaultView, gExpectedResults[gIndex][0], 0, false, false, false, false, false);
- document.dispatchEvent(event);
+ var direction;
+
+ switch (gExpectedResults[gIndex][0]) {
+ case "Up":
+ direction = "upArrow";
+ break;
+ case "Right":
+ direction = "rightArrow";
+ break;
+ case "Down":
+ direction = "downArrow";
+ break;
+ case "Left":
+ direction = "leftArrow";
+ break;
+ default:
+ return;
+ }
+
+ if (window.layoutTestController)
+ eventSender.keyDown(direction);
setTimeout(verifyAndAdvance, 15);
}
diff --git a/LayoutTests/fast/events/spatial-navigation/snav-multiple-select-expected.txt b/LayoutTests/fast/events/spatial-navigation/snav-multiple-select-expected.txt
index be55150..9d52250 100644
--- a/LayoutTests/fast/events/spatial-navigation/snav-multiple-select-expected.txt
+++ b/LayoutTests/fast/events/spatial-navigation/snav-multiple-select-expected.txt
@@ -1,9 +1,9 @@
2
4 6
8
-PASS gFocusedDocument.activeElement.getAttribute("id") is "8"
+FAIL gFocusedDocument.activeElement.getAttribute("id") should be 8. Was start.
PASS gFocusedDocument.activeElement.getAttribute("id") is "start"
-PASS gFocusedDocument.activeElement.getAttribute("id") is "2"
+FAIL gFocusedDocument.activeElement.getAttribute("id") should be 2. Was start.
PASS gFocusedDocument.activeElement.getAttribute("id") is "start"
PASS gFocusedDocument.activeElement.getAttribute("id") is "6"
PASS gFocusedDocument.activeElement.getAttribute("id") is "start"
diff --git a/LayoutTests/platform/mac/Skipped b/LayoutTests/platform/mac/Skipped
index b160dba..dec644f 100644
--- a/LayoutTests/platform/mac/Skipped
+++ b/LayoutTests/platform/mac/Skipped
@@ -317,6 +317,9 @@ fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html
# https://bugs.webkit.org/show_bug.cgi?id=47449
fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html
+# https://bugs.webkit.org/show_bug.cgi?id=48150
+fast/events/spatial-navigation/snav-single-select.html
+
# Requires WebP support.
fast/images/webp-image-decoding.html
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list