[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

commit-queue at webkit.org commit-queue at webkit.org
Wed Dec 22 15:30:22 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 851e5b8fe1b9bdb85a11db3422e015f90a336799
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Fri Nov 5 08:29:28 2010 +0000

    2010-11-05  John Reck  <jreck at google.com>
    
            Reviewed by Nikolas Zimmermann.
    
            The change to SVGPropertyTearOff by CodeGeneratorV8.pm caused two build failures
            for Android. One was a missing SVGPropertyTearOff.h include, the other was a
            missing forward declaration of FloatRect. Seems to be the result of:
            https://bugs.webkit.org/show_bug.cgi?id=48204
    
            Bug: https://bugs.webkit.org/show_bug.cgi?id=49025
    
            No tests needed, fixes build issue.
    
            * bindings/scripts/CodeGeneratorV8.pm:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 3ef9a13..25f135b 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,18 @@
+2010-11-05  John Reck  <jreck at google.com>
+
+        Reviewed by Nikolas Zimmermann.
+
+        The change to SVGPropertyTearOff by CodeGeneratorV8.pm caused two build failures
+        for Android. One was a missing SVGPropertyTearOff.h include, the other was a 
+        missing forward declaration of FloatRect. Seems to be the result of:
+        https://bugs.webkit.org/show_bug.cgi?id=48204
+
+        Bug: https://bugs.webkit.org/show_bug.cgi?id=49025
+
+        No tests needed, fixes build issue.
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+
 2010-11-05  Rob Buis  <rwlbuis at gmail.com>
 
         Reviewed by David Hyatt.
diff --git a/WebCore/bindings/scripts/CodeGeneratorV8.pm b/WebCore/bindings/scripts/CodeGeneratorV8.pm
index e26bb49..6cb3414 100644
--- a/WebCore/bindings/scripts/CodeGeneratorV8.pm
+++ b/WebCore/bindings/scripts/CodeGeneratorV8.pm
@@ -278,6 +278,7 @@ sub GenerateHeader
             push(@headerContent, "\ntemplate<typename PropertyType> class SVGListPropertyTearOff;\n");
         }
     }
+    push(@headerContent, "\nclass FloatRect;\n") if $svgPropertyType && $svgPropertyType eq "FloatRect";
     push(@headerContent, "\nclass $className {\n");
 
     my $nativeType = GetNativeTypeForConversions($dataNode, $interfaceName);
@@ -927,6 +928,7 @@ END
         push(@implContentDecls, "    return toV8(static_cast<$svgNativeType*>($result));\n");
     } elsif ($codeGenerator->IsSVGTypeNeedingTearOff($attrType) and not $implClassName =~ /List$/) {
         $implIncludes{"V8$attrType.h"} = 1;
+        $implIncludes{"SVGPropertyTearOff.h"} = 1;
         my $tearOffType = $codeGenerator->GetSVGTypeNeedingTearOff($attrType);
         if ($tearOffType =~ /SVGStaticListPropertyTearOff/) {
             my $extraImp = "GetOwnerElementForType<$implClassName, IsDerivedFromSVGElement<$implClassName>::value>::ownerElement(imp), ";

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list