[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
benjamin.poulain at nokia.com
benjamin.poulain at nokia.com
Wed Dec 22 16:13:49 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit be697bfd57cda29eacc94d2126f3ae97a16d992a
Author: benjamin.poulain at nokia.com <benjamin.poulain at nokia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri Nov 19 21:15:43 2010 +0000
2010-11-19 Benjamin Poulain <benjamin.poulain at nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] mask-box-image renders wrong in certain conditions
https://bugs.webkit.org/show_bug.cgi?id=43476
Qt does not follow the same convention as the other port
when rendering a pixmap with null width of height. When one
of those dimension is null, we should ignore the painting call
to behave like the other ports.
* platform/graphics/qt/ImageQt.cpp:
(WebCore::Image::drawPattern):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index aab0fa5..59d40d6 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,18 @@
+2010-11-19 Benjamin Poulain <benjamin.poulain at nokia.com>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] mask-box-image renders wrong in certain conditions
+ https://bugs.webkit.org/show_bug.cgi?id=43476
+
+ Qt does not follow the same convention as the other port
+ when rendering a pixmap with null width of height. When one
+ of those dimension is null, we should ignore the painting call
+ to behave like the other ports.
+
+ * platform/graphics/qt/ImageQt.cpp:
+ (WebCore::Image::drawPattern):
+
2010-11-18 Zhenyao Mo <zmo at google.com>
Reviewed by Kenneth Russell.
diff --git a/WebCore/platform/graphics/qt/ImageQt.cpp b/WebCore/platform/graphics/qt/ImageQt.cpp
index 26179ad..459a8b5 100644
--- a/WebCore/platform/graphics/qt/ImageQt.cpp
+++ b/WebCore/platform/graphics/qt/ImageQt.cpp
@@ -102,12 +102,13 @@ void Image::drawPattern(GraphicsContext* ctxt, const FloatRect& tileRect, const
if (!framePixmap) // If it's too early we won't have an image yet.
return;
+ // Qt interprets 0 width/height as full width/height so just short circuit.
QRectF dr = QRectF(destRect).normalized();
- if (!dr.width() || !dr.height()) // Qt interprets 0 width/height as full width/height so just short circuit.
+ QRect tr = QRectF(tileRect).toRect().normalized();
+ if (!dr.width() || !dr.height() || !tr.width() || !tr.height())
return;
QPixmap pixmap = *framePixmap;
- QRect tr = QRectF(tileRect).toRect().normalized();
if (tr.x() || tr.y() || tr.width() != pixmap.width() || tr.height() != pixmap.height())
pixmap = pixmap.copy(tr);
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list