[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

commit-queue at webkit.org commit-queue at webkit.org
Wed Dec 22 13:24:33 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 4b2ea24a8d158220462a808244522dbbdd410517
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Sep 14 16:19:32 2010 +0000

    2010-09-14  Kwang Yul Seo  <skyul at company100.net>
    
            Reviewed by Kent Tamura.
    
            [BREWMP] Always set LeftButton in PlatformMouseEvent
            https://bugs.webkit.org/show_bug.cgi?id=45705
    
            AEE_POINTER_GET_MOUSE_MODIFIERS always returns 0, so it is impossible to know
            which button is pressed or released. The current code erroneously sets NoButton.
            Set LeftButton unconditionally because Brew MP usually runs on touch device.
    
            * platform/brew/PlatformMouseEventBrew.cpp:
            (WebCore::PlatformMouseEvent::PlatformMouseEvent):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index bf44769..e92629b 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2010-09-14  Kwang Yul Seo  <skyul at company100.net>
+
+        Reviewed by Kent Tamura.
+
+        [BREWMP] Always set LeftButton in PlatformMouseEvent
+        https://bugs.webkit.org/show_bug.cgi?id=45705
+
+        AEE_POINTER_GET_MOUSE_MODIFIERS always returns 0, so it is impossible to know
+        which button is pressed or released. The current code erroneously sets NoButton.
+        Set LeftButton unconditionally because Brew MP usually runs on touch device.
+
+        * platform/brew/PlatformMouseEventBrew.cpp:
+        (WebCore::PlatformMouseEvent::PlatformMouseEvent):
+
 2010-09-14  Yury Semikhatsky  <yurys at chromium.org>
 
         Reviewed by Andreas Kling.
diff --git a/WebCore/platform/brew/PlatformMouseEventBrew.cpp b/WebCore/platform/brew/PlatformMouseEventBrew.cpp
index 32593e6..a118d19 100644
--- a/WebCore/platform/brew/PlatformMouseEventBrew.cpp
+++ b/WebCore/platform/brew/PlatformMouseEventBrew.cpp
@@ -65,15 +65,10 @@ PlatformMouseEvent::PlatformMouseEvent(AEEEvent event, uint16 wParam, uint32 dwP
     m_altKey   = keyModifiers & (KB_LALT | KB_RALT);
     m_metaKey  = m_altKey;
 
-    uint16 mouseModifiers = AEE_POINTER_GET_MOUSE_MODIFIERS(dwParamStr);
-    if (mouseModifiers & AEE_POINTER_MOUSE_LBUTTON)
-        m_button = LeftButton;
-    else if (mouseModifiers & AEE_POINTER_MOUSE_RBUTTON)
-        m_button = RightButton;
-    else if (mouseModifiers & AEE_POINTER_MOUSE_MBUTTON)
-        m_button = MiddleButton;
-    else
-        m_button = NoButton;
+    // AEE_POINTER_GET_MOUSE_MODIFIERS(dwParamStr) always returns 0,
+    // so it is impossible to know which button is pressed or released.
+    // Just use LeftButton because Brew MP usually runs on touch device.
+    m_button = LeftButton;
 
     // AEE_POINTER_GET_TIME returns milliseconds
     m_timestamp = AEE_POINTER_GET_TIME(dwParamStr) * 0.001;

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list