[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

abarth at webkit.org abarth at webkit.org
Wed Dec 22 13:33:01 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 44f971e7798beb5efb665c4e61b0a4edc2e72e00
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Sep 20 04:26:46 2010 +0000

    2010-09-19  Adam Barth  <abarth at webkit.org>
    
            Reviewed by Eric Seidel.
    
            Move reviewtool to action=review
            https://bugs.webkit.org/show_bug.cgi?id=46071
    
            This patch removes the old Review Patch screen and moves the new
            reviewtool from Pretty Diff to Review Patch.
    
            * attachment.cgi:
            * code-review.js:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/BugsSite/ChangeLog b/BugsSite/ChangeLog
index 5ae4f41..a7b8079 100644
--- a/BugsSite/ChangeLog
+++ b/BugsSite/ChangeLog
@@ -1,5 +1,18 @@
 2010-09-19  Adam Barth  <abarth at webkit.org>
 
+        Reviewed by Eric Seidel.
+
+        Move reviewtool to action=review
+        https://bugs.webkit.org/show_bug.cgi?id=46071
+
+        This patch removes the old Review Patch screen and moves the new
+        reviewtool from Pretty Diff to Review Patch.
+
+        * attachment.cgi:
+        * code-review.js:
+
+2010-09-19  Adam Barth  <abarth at webkit.org>
+
         Review tool UI tweak.  This patch lengthens the status bubbles so all
         the bubble fit (even when they have numbers inside).
 
diff --git a/BugsSite/attachment.cgi b/BugsSite/attachment.cgi
index 07800d3..90c279d 100755
--- a/BugsSite/attachment.cgi
+++ b/BugsSite/attachment.cgi
@@ -129,7 +129,7 @@ elsif ($action eq "edit")
 #if WEBKIT_CHANGES
 elsif ($action eq "review")
 {
-    edit("review");
+    prettyPatch();
 }
 elsif ($action eq "reviewform")
 {
diff --git a/BugsSite/code-review.js b/BugsSite/code-review.js
index c9042a5..2e4b3ef 100644
--- a/BugsSite/code-review.js
+++ b/BugsSite/code-review.js
@@ -31,9 +31,11 @@
     }
   }
 
-  // Attempt to activate only in the "Formatted Diff" context.
+  // Attempt to activate only in the "Review Patch" context.
   if (window.top != window)
     return;
+  if (!window.location.search.match(/action=review/))
+    return;
   var attachment_id = determineAttachmentID();
   if (!attachment_id)
     return;

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list