[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
abarth at webkit.org
abarth at webkit.org
Wed Dec 22 13:33:08 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 9dd9e32f7de319ae6d75b4069102d0664d181978
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Mon Sep 20 06:16:31 2010 +0000
2010-09-19 Adam Barth <abarth at webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Publish button should actually publish the review comments
https://bugs.webkit.org/show_bug.cgi?id=46074
Instead of showing the confirmation lightbox, the Publish button now
publishes the comments directly. If there's demand for a "Preview"
button, we can find a way to add that feature.
* code-review.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/BugsSite/ChangeLog b/BugsSite/ChangeLog
index a7b8079..fdabb05 100644
--- a/BugsSite/ChangeLog
+++ b/BugsSite/ChangeLog
@@ -2,6 +2,19 @@
Reviewed by Eric Seidel.
+ [reviewtool] Publish button should actually publish the review comments
+ https://bugs.webkit.org/show_bug.cgi?id=46074
+
+ Instead of showing the confirmation lightbox, the Publish button now
+ publishes the comments directly. If there's demand for a "Preview"
+ button, we can find a way to add that feature.
+
+ * code-review.js:
+
+2010-09-19 Adam Barth <abarth at webkit.org>
+
+ Reviewed by Eric Seidel.
+
Move reviewtool to action=review
https://bugs.webkit.org/show_bug.cgi?id=46071
diff --git a/BugsSite/code-review.js b/BugsSite/code-review.js
index 2e4b3ef..3d63e59 100644
--- a/BugsSite/code-review.js
+++ b/BugsSite/code-review.js
@@ -452,7 +452,6 @@
comment_with_context.push('\n' + comment);
comments_in_context.push(comment_with_context.join('\n'));
});
- $('#comment_form').removeClass('inactive');
var comment = $('.overallComments textarea').val().trim();
if (comment != '')
comment += '\n\n';
@@ -467,5 +466,6 @@
return;
$(this).attr('selectedIndex', control.attr('selectedIndex'));
});
+ review_form.find('form').submit();
});
})();
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list