[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-10851-g50815da

ager at chromium.org ager at chromium.org
Wed Dec 22 18:36:08 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 838e3b9cfce5df7b61690e6f15fa309d973dc2cc
Author: ager at chromium.org <ager at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Dec 14 13:39:06 2010 +0000

    2010-12-14  Mads Ager  <ager at chromium.org>
    
            Reviewed by Pavel Feldman.
    
            [V8] Reflected unsigned attributes should be in the range [0, 2^31)
            https://bugs.webkit.org/show_bug.cgi?id=51023
    
            Remove test that now passes from chromium test expectations.
    
            * platform/chromium/test_expectations.txt:
    2010-12-14  Mads Ager  <ager at chromium.org>
    
            Reviewed by Pavel Feldman.
    
            [V8] Reflected unsigned attributes should be in the range [0, 2^31)
            https://bugs.webkit.org/show_bug.cgi?id=51023
    
            Follow the changes made to CodeGeneratorJS.pm to return 0 for
            reflected unsigned attributes that are outside the allowed range.
            See https://bugs.webkit.org/show_bug.cgi?id=50472
    
            * bindings/scripts/CodeGeneratorV8.pm:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 1ad46e3..480668e 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,14 @@
+2010-12-14  Mads Ager  <ager at chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        [V8] Reflected unsigned attributes should be in the range [0, 2^31)
+        https://bugs.webkit.org/show_bug.cgi?id=51023
+
+        Remove test that now passes from chromium test expectations.
+
+        * platform/chromium/test_expectations.txt:
+
 2010-12-14  Mario Sanchez Prada  <msanchez at igalia.com>
 
         Unreviewed, skipping failing test in the release bots.
diff --git a/LayoutTests/platform/chromium/test_expectations.txt b/LayoutTests/platform/chromium/test_expectations.txt
index 24e9340..61bd700 100644
--- a/LayoutTests/platform/chromium/test_expectations.txt
+++ b/LayoutTests/platform/chromium/test_expectations.txt
@@ -3212,7 +3212,6 @@ BUG_VITALYR : fast/images/gray-scale-jpeg-with-color-profile.html = MISSING
 BUG_VITALYR MAC : tables/mozilla/bugs/bug82946-2.html = IMAGE
 
 // WebKit roll 73514:73595
-BUG66018 : fast/html/marquee-element.html = TEXT
 BUG66019 : fast/regex/pcre-test-1.html = TEXT
 
 // Mostly-flaky timeouts
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 564756a..7b92fde 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2010-12-14  Mads Ager  <ager at chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        [V8] Reflected unsigned attributes should be in the range [0, 2^31)
+        https://bugs.webkit.org/show_bug.cgi?id=51023
+
+        Follow the changes made to CodeGeneratorJS.pm to return 0 for
+        reflected unsigned attributes that are outside the allowed range.
+        See https://bugs.webkit.org/show_bug.cgi?id=50472
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+
 2010-12-14  Charlie Reis  <creis at chromium.org>
 
         Reviewed by Darin Adler.
diff --git a/WebCore/bindings/scripts/CodeGeneratorV8.pm b/WebCore/bindings/scripts/CodeGeneratorV8.pm
index d339d6a..f50e74a 100644
--- a/WebCore/bindings/scripts/CodeGeneratorV8.pm
+++ b/WebCore/bindings/scripts/CodeGeneratorV8.pm
@@ -3088,6 +3088,14 @@ sub ReturnNativeToJSValue
     return "return v8Boolean($value)" if $type eq "boolean";
     return "return v8::Handle<v8::Value>()" if $type eq "void";     # equivalent to v8::Undefined()
 
+    # HTML5 says that unsigned reflected attributes should be in the range
+    # [0, 2^31). When a value isn't in this range, a default value (or 0)
+    # should be returned instead.
+    if ($signature->extendedAttributes->{"Reflect"} and ($type eq "unsigned long" or $type eq "unsigned short")) {
+        $value =~ s/getUnsignedIntegralAttribute/getIntegralAttribute/g;
+        return "return v8::Integer::NewFromUnsigned(std::max(0, " . $value . "))";
+    }
+
     # For all the types where we use 'int' as the representation type,
     # we use Integer::New which has a fast Smi conversion check.
     my $nativeType = GetNativeType($type);

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list