[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-10851-g50815da
ojan at chromium.org
ojan at chromium.org
Wed Dec 22 18:46:24 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 325916cb789e1a63b8426e388af8534e3bb9e218
Author: ojan at chromium.org <ojan at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri Dec 17 18:33:47 2010 +0000
2010-12-17 Ojan Vafai <ojan at chromium.org>
Speculative fix for the code review tool in Firefox.
Fixes a JS error and makes the status bubble mostly work
if postMessage is not supported.
* PrettyPatch/PrettyPatch.rb:
* code-review.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/BugsSite/ChangeLog b/BugsSite/ChangeLog
index 75e4d49..d4627de 100644
--- a/BugsSite/ChangeLog
+++ b/BugsSite/ChangeLog
@@ -1,3 +1,12 @@
+2010-12-17 Ojan Vafai <ojan at chromium.org>
+
+ Speculative fix for the code review tool in Firefox.
+ Fixes a JS error and makes the status bubble mostly work
+ if postMessage is not supported.
+
+ * PrettyPatch/PrettyPatch.rb:
+ * code-review.js:
+
2010-12-15 Ojan Vafai <ojan at chromium.org>
Reviewed by Adam Barth.
diff --git a/BugsSite/PrettyPatch/PrettyPatch.rb b/BugsSite/PrettyPatch/PrettyPatch.rb
index 1dd1681..d7f2d58 100644
--- a/BugsSite/PrettyPatch/PrettyPatch.rb
+++ b/BugsSite/PrettyPatch/PrettyPatch.rb
@@ -349,6 +349,9 @@ body {
}
.statusBubble {
+ /* The width/height get set to the bubble contents via postMessage on browsers that support it. */
+ width: 450px;
+ height: 20px;
margin: 2px 2px 0 0;
border: none;
vertical-align: middle;
diff --git a/BugsSite/code-review.js b/BugsSite/code-review.js
index c887220..2a3b2c9 100644
--- a/BugsSite/code-review.js
+++ b/BugsSite/code-review.js
@@ -255,9 +255,11 @@
if (e.origin != 'https://webkit-commit-queue.appspot.com')
return;
- $('.statusBubble')[0].style.height = e.data.height;
- $('.statusBubble')[0].style.width = e.data.width;
- });
+ if (e.data.height) {
+ $('.statusBubble')[0].style.height = e.data.height;
+ $('.statusBubble')[0].style.width = e.data.width;
+ }
+ }, false);
function handleStatusBubbleLoad(e) {
e.target.contentWindow.postMessage('containerMetrics', 'https://webkit-commit-queue.appspot.com');
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list