[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

[commit-queue at webkit.org]

The following commit has been merged in the debian/experimental branch:
commit dcf3f0ff7fa4a047ed1f26ba2fecc416b9b8009f
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Sun Nov 28 18:51:38 2010 +0000

    2010-11-28  Antonio Gomes  <agomes at rim.com>
    
            Reviewed by Kenneth Rohde Christiansen.
    
            Spatial Navigation: use isSpatialNaviagtionEnabled from SpatialNavigation.h in HTMLInputElement::defaultEventHandler
            https://bugs.webkit.org/show_bug.cgi?id=50131
    
            For all isSpatialNavigationEnabled calls throughout WebCore, we decided to use the static method in
            SpatialNavigation.h instead of directly checking from the one in Settings.h. Reason: in a soon future,
            there  will be a isCaretBrowsing check incorporated into this method (and probably renaming it accordingly)
            to avoid feature conflicts (spatial navigation x caret browsing).
    
            No new tests needed.
    
            * html/HTMLInputElement.cpp:
            (WebCore::HTMLInputElement::defaultEventHandler):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index ef6d765..98604f6 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,20 @@
+2010-11-28  Antonio Gomes  <agomes at rim.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Spatial Navigation: use isSpatialNaviagtionEnabled from SpatialNavigation.h in HTMLInputElement::defaultEventHandler
+        https://bugs.webkit.org/show_bug.cgi?id=50131
+
+        For all isSpatialNavigationEnabled calls throughout WebCore, we decided to use the static method in
+        SpatialNavigation.h instead of directly checking from the one in Settings.h. Reason: in a soon future,
+        there  will be a isCaretBrowsing check incorporated into this method (and probably renaming it accordingly)
+        to avoid feature conflicts (spatial navigation x caret browsing).
+
+        No new tests needed.
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::defaultEventHandler):
+
 2010-11-27  Benjamin Kalman  <kalman at chromium.org>
 
         Reviewed by Darin Adler.
diff --git a/WebCore/html/HTMLInputElement.cpp b/WebCore/html/HTMLInputElement.cpp
index fcb2be8..55fa195 100644
--- a/WebCore/html/HTMLInputElement.cpp
+++ b/WebCore/html/HTMLInputElement.cpp
@@ -1411,7 +1411,7 @@ void HTMLInputElement::defaultEventHandler(Event* evt)
             // Tested in WinIE, and even for RTL, left still means previous radio button (and so moves
             // to the right).  Seems strange, but we'll match it.
             // However, when using Spatial Navigation, we need to be able to navigate without changing the selection.
-            if (!document()->frame() || !document()->frame()->settings() || !document()->frame()->settings()->isSpatialNavigationEnabled()) {
+            if (!isSpatialNavigationEnabled(document()->frame())) {
                 bool forward = (key == "Down" || key == "Right");
 
                 // We can only stay within the form's children if the form hasn't been demoted to a leaf because

-- 
WebKit Debian packaging