[SCM] WebKit Debian packaging branch, debian/experimental, updated. debian/1.3.8-1-142-g786665c

[commit-queue at webkit.org]

The following commit has been merged in the debian/experimental branch:
commit 7b050cace59acc6cbe0b48d6f69958224b0cac14
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Dec 22 11:38:33 2010 +0000

    2010-12-22  Dai Mikurube  <dmikurube at google.com>
    
            Reviewed by Kent Tamura.
    
            https://bugs.webkit.org/show_bug.cgi?id=51289
            Initial state of checkValidity() and :invalid are incorrect with <select required>
    
            * fast/css/pseudo-valid-007-expected.txt:
            * fast/css/pseudo-valid-007.html:
            * fast/forms/checkValidity-002-expected.txt:
            * fast/forms/checkValidity-002.html:
    2010-12-22  Dai Mikurube  <dmikurube at google.com>
    
            Reviewed by Kent Tamura.
    
            https://bugs.webkit.org/show_bug.cgi?id=51289
            Initial state of checkValidity() and :invalid are incorrect with <select required>
    
            * html/HTMLSelectElement.cpp:
            (WebCore::HTMLSelectElement::childrenChanged): setNeedsValidityCheck() after <select>'s children change.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 34d0f0c..385386c 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,15 @@
+2010-12-22  Dai Mikurube  <dmikurube at google.com>
+
+        Reviewed by Kent Tamura.
+
+        https://bugs.webkit.org/show_bug.cgi?id=51289
+        Initial state of checkValidity() and :invalid are incorrect with <select required>
+
+        * fast/css/pseudo-valid-007-expected.txt:
+        * fast/css/pseudo-valid-007.html:
+        * fast/forms/checkValidity-002-expected.txt:
+        * fast/forms/checkValidity-002.html:
+
 2010-12-22  Alexander Pavlov  <apavlov at chromium.org>
 
         Reviewed by Joseph Pecoraro.
diff --git a/LayoutTests/fast/css/pseudo-valid-007-expected.txt b/LayoutTests/fast/css/pseudo-valid-007-expected.txt
index 106e9d3..0716c0b 100644
--- a/LayoutTests/fast/css/pseudo-valid-007-expected.txt
+++ b/LayoutTests/fast/css/pseudo-valid-007-expected.txt
@@ -3,7 +3,8 @@ This test performs a check for the :valid CSS selector on a select element.
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-
+ 
+PASS document.defaultView.getComputedStyle(v[i], null).getPropertyValue('background-color') is 'rgb(0, 255, 0)'
 PASS document.defaultView.getComputedStyle(v[i], null).getPropertyValue('background-color') is 'rgb(0, 255, 0)'
 PASS successfullyParsed is true
 
diff --git a/LayoutTests/fast/css/pseudo-valid-007.html b/LayoutTests/fast/css/pseudo-valid-007.html
index fdd4565..b647e54 100644
--- a/LayoutTests/fast/css/pseudo-valid-007.html
+++ b/LayoutTests/fast/css/pseudo-valid-007.html
@@ -13,6 +13,7 @@
 <p id="description"></p>
 <form method="get">
 <select name="victim"><option>Lorem ipsum</option></select>
+<select name="victim" required><option>empty</option><option>another</option></select>
 </form>
 <div id="console"></div>
 <script>
diff --git a/LayoutTests/fast/forms/checkValidity-002-expected.txt b/LayoutTests/fast/forms/checkValidity-002-expected.txt
index 8388828..b54c151 100644
--- a/LayoutTests/fast/forms/checkValidity-002-expected.txt
+++ b/LayoutTests/fast/forms/checkValidity-002-expected.txt
@@ -3,10 +3,11 @@ This test checks if checkValidity() returns correctly a false (meaning error) re
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-    
+     
 PASS checkValidityFor("input-empty") is false
 PASS checkValidityFor("input-pattern-mismatch") is false
 PASS checkValidityFor("textarea") is false
+PASS checkValidityFor("select-no-explicit-value") is true
 PASS checkValidityFor("select-placeholder") is false
 PASS checkValidityFor("select-non-placeholder") is true
 PASS successfullyParsed is true
diff --git a/LayoutTests/fast/forms/checkValidity-002.html b/LayoutTests/fast/forms/checkValidity-002.html
index 662f6eb..ed90533 100644
--- a/LayoutTests/fast/forms/checkValidity-002.html
+++ b/LayoutTests/fast/forms/checkValidity-002.html
@@ -10,6 +10,10 @@
 <input id="input-empty" name="victim" type="text" required/>
 <input id="input-pattern-mismatch" name="victim" type="text" pattern="Lorem ipsum" value="Loremipsum"/>
 <textarea id="textarea" name="victim" required></textarea>
+<select id="select-no-explicit-value" required>
+  <option>empty</option>
+  <option>another</option>
+</select>
 <select id="select-placeholder" name="victim" required>
   <option value="" selected />
   <option value="X">X</option>
@@ -30,6 +34,7 @@
     shouldBeFalse('checkValidityFor("input-empty")');
     shouldBeFalse('checkValidityFor("input-pattern-mismatch")');
     shouldBeFalse('checkValidityFor("textarea")');
+    shouldBeTrue('checkValidityFor("select-no-explicit-value")');
     shouldBeFalse('checkValidityFor("select-placeholder")');
     shouldBeTrue('checkValidityFor("select-non-placeholder")');
 
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 2a52f27..543cdfb 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,13 @@
+2010-12-22  Dai Mikurube  <dmikurube at google.com>
+
+        Reviewed by Kent Tamura.
+
+        https://bugs.webkit.org/show_bug.cgi?id=51289
+        Initial state of checkValidity() and :invalid are incorrect with <select required>
+
+        * html/HTMLSelectElement.cpp:
+        (WebCore::HTMLSelectElement::childrenChanged): setNeedsValidityCheck() after <select>'s children change.
+
 2010-12-22  Alexander Pavlov  <apavlov at chromium.org>
 
         Reviewed by Joseph Pecoraro.
diff --git a/WebCore/html/HTMLSelectElement.cpp b/WebCore/html/HTMLSelectElement.cpp
index 968f629..2dc882d 100644
--- a/WebCore/html/HTMLSelectElement.cpp
+++ b/WebCore/html/HTMLSelectElement.cpp
@@ -343,6 +343,7 @@ void HTMLSelectElement::recalcListItemsIfNeeded()
 void HTMLSelectElement::childrenChanged(bool changedByParser, Node* beforeChange, Node* afterChange, int childCountDelta)
 {
     setRecalcListItems();
+    setNeedsValidityCheck();
     HTMLFormControlElementWithState::childrenChanged(changedByParser, beforeChange, afterChange, childCountDelta);
     
     if (AXObjectCache::accessibilityEnabled() && renderer())

-- 
WebKit Debian packaging