[SCM] WebKit Debian packaging branch, debian/experimental, updated. debian/1.3.8-1-142-g786665c
ariya at webkit.org
ariya at webkit.org
Mon Dec 27 16:28:11 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit dc51feca8d7e4e87657dea0f7d9b48bf1b554faf
Author: ariya at webkit.org <ariya at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Dec 21 23:26:20 2010 +0000
2010-12-21 Ariya Hidayat <ariya at sencha.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=49774
Need to scale translation values in matrix() by the zoom factor.
* fast/transforms/matrix-with-zoom-expected.checksum: Added.
* fast/transforms/matrix-with-zoom-expected.png: Added.
* fast/transforms/matrix-with-zoom-expected.txt: Added.
* fast/transforms/matrix-with-zoom.html: Added.
2010-12-21 Ariya Hidayat <ariya at sencha.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=49774
Need to scale translation values in matrix() by the zoom factor.
Test: fast/transforms/matrix-with-zoom.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::createTransformOperations):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index c4f1e45..350f454 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,15 @@
+2010-12-21 Ariya Hidayat <ariya at sencha.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=49774
+ Need to scale translation values in matrix() by the zoom factor.
+
+ * fast/transforms/matrix-with-zoom-expected.checksum: Added.
+ * fast/transforms/matrix-with-zoom-expected.png: Added.
+ * fast/transforms/matrix-with-zoom-expected.txt: Added.
+ * fast/transforms/matrix-with-zoom.html: Added.
+
2010-12-21 Oliver Hunt <oliver at apple.com>
Reviewed by Gavin Barraclough.
diff --git a/LayoutTests/fast/transforms/matrix-with-zoom-expected.checksum b/LayoutTests/fast/transforms/matrix-with-zoom-expected.checksum
new file mode 100644
index 0000000..0b1c4dd
--- /dev/null
+++ b/LayoutTests/fast/transforms/matrix-with-zoom-expected.checksum
@@ -0,0 +1 @@
+e1a5a5c4303d2d4891700085b9702312
\ No newline at end of file
diff --git a/LayoutTests/fast/transforms/matrix-with-zoom-expected.png b/LayoutTests/fast/transforms/matrix-with-zoom-expected.png
new file mode 100644
index 0000000..9f3a5ca
Binary files /dev/null and b/LayoutTests/fast/transforms/matrix-with-zoom-expected.png differ
diff --git a/LayoutTests/fast/transforms/matrix-with-zoom-expected.txt b/LayoutTests/fast/transforms/matrix-with-zoom-expected.txt
new file mode 100644
index 0000000..3a2a86a
--- /dev/null
+++ b/LayoutTests/fast/transforms/matrix-with-zoom-expected.txt
@@ -0,0 +1,9 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+ RenderBody {BODY} at (0,0) size 800x600
+layer at (48,72) size 120x120
+ RenderBlock (positioned) {DIV} at (48,72) size 120x120 [bgcolor=#FF0000]
+layer at (48,72) size 120x120
+ RenderBlock (positioned) {DIV} at (48,72) size 120x120 [bgcolor=#008000]
diff --git a/LayoutTests/fast/transforms/matrix-with-zoom.html b/LayoutTests/fast/transforms/matrix-with-zoom.html
new file mode 100644
index 0000000..af51f57
--- /dev/null
+++ b/LayoutTests/fast/transforms/matrix-with-zoom.html
@@ -0,0 +1,64 @@
+<html>
+<head>
+<style>
+body {
+ zoom: 1.2;
+ padding: 0;
+ margin: 0;
+}
+
+.box {
+ width: 100px;
+ height: 100px;
+ background-color: blue;
+ position: absolute;
+ top: 60px;
+ left: 40px;
+}
+
+.translate {
+ -webkit-transform: translate(100px, 50px);
+ background-color: red;
+}
+
+.matrix {
+ -webkit-transform: matrix(1, 0, 0, 1, 100, 50);
+ background-color: green;
+}
+</style>
+<script type="text/javascript">
+
+function runTest() {
+
+ if (!window.layoutTestController) {
+
+ var id1 = "a";
+ var id2 = "b";
+ var element1 = document.getElementById(id1);
+ var element2 = document.getElementById(id2);
+ var x1 = webkitConvertPointFromNodeToPage(element1, new WebKitPoint(0,0)).x;
+ var y1 = webkitConvertPointFromNodeToPage(element1, new WebKitPoint(0,0)).y;
+ var x2 = webkitConvertPointFromNodeToPage(element2, new WebKitPoint(0,0)).x;
+ var y2 = webkitConvertPointFromNodeToPage(element2, new WebKitPoint(0,0)).y;
+
+ var resultString = '';
+ if (x1 == x2 && y1 == y2) {
+ resultString += "PASS - Element " + id1 + " and Element " + id2 + " had identical positions";
+ } else {
+ resultString += "FAIL - Element " + id1 + " and Element " + id2 + " had different positions";
+ }
+
+ document.body.appendChild(document.createTextNode(resultString));
+ }
+}
+</script>
+</head>
+<body onload="runTest();">
+
+<!-- You should see green box only. If you see red, the test has failed -->
+
+<div id='a' class="box translate"></div>
+<div id='b' class="box matrix"></div>
+
+</body>
+</html>
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 30006da..6964e9a 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2010-12-21 Ariya Hidayat <ariya at sencha.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=49774
+ Need to scale translation values in matrix() by the zoom factor.
+
+ Test: fast/transforms/matrix-with-zoom.html
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::createTransformOperations):
+
2010-12-21 Jian Li <jianli at chromium.org>
Reviewed by Darin Adler.
diff --git a/WebCore/css/CSSStyleSelector.cpp b/WebCore/css/CSSStyleSelector.cpp
index fc1cecf..4f47432 100644
--- a/WebCore/css/CSSStyleSelector.cpp
+++ b/WebCore/css/CSSStyleSelector.cpp
@@ -6821,8 +6821,8 @@ bool CSSStyleSelector::createTransformOperations(CSSValue* inValue, RenderStyle*
double b = static_cast<CSSPrimitiveValue*>(transformValue->itemWithoutBoundsCheck(1))->getDoubleValue();
double c = static_cast<CSSPrimitiveValue*>(transformValue->itemWithoutBoundsCheck(2))->getDoubleValue();
double d = static_cast<CSSPrimitiveValue*>(transformValue->itemWithoutBoundsCheck(3))->getDoubleValue();
- double e = static_cast<CSSPrimitiveValue*>(transformValue->itemWithoutBoundsCheck(4))->getDoubleValue();
- double f = static_cast<CSSPrimitiveValue*>(transformValue->itemWithoutBoundsCheck(5))->getDoubleValue();
+ double e = zoomFactor * static_cast<CSSPrimitiveValue*>(transformValue->itemWithoutBoundsCheck(4))->getDoubleValue();
+ double f = zoomFactor * static_cast<CSSPrimitiveValue*>(transformValue->itemWithoutBoundsCheck(5))->getDoubleValue();
operations.operations().append(MatrixTransformOperation::create(a, b, c, d, e, f));
break;
}
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list