[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.19-706-ge5415e9

eric at webkit.org eric at webkit.org
Thu Feb 4 21:22:45 UTC 2010


The following commit has been merged in the webkit-1.1 branch:
commit d35c12d2f43f5a5f7eba5c699c81f2031a3d25b0
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Jan 21 04:54:46 2010 +0000

    2010-01-20  Stephen White  <senorblanco at chromium.org>
    
            Reviewed by David Levin.
    
            Disable the "seatbelt" coordinate validation functions in the
            Skia graphics layer.  We believe all the underlying bugs have
            been fixed, but just in case we're being overly optimistic, this
            leaves in the code for an easy revert.
    
            https://bugs.webkit.org/show_bug.cgi?id=33908
            Exercised by many layout tests.
    
            * platform/graphics/skia/GraphicsContextSkia.cpp:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 63b44ef..9094969 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2010-01-20  Stephen White  <senorblanco at chromium.org>
+
+        Reviewed by David Levin.
+
+        Disable the "seatbelt" coordinate validation functions in the
+        Skia graphics layer.  We believe all the underlying bugs have
+        been fixed, but just in case we're being overly optimistic, this
+        leaves in the code for an easy revert.
+
+        https://bugs.webkit.org/show_bug.cgi?id=33908
+        Exercised by many layout tests.
+
+        * platform/graphics/skia/GraphicsContextSkia.cpp:
+
 2010-01-20  Kent Tamura  <tkent at chromium.org>
 
         Reviewed by Darin Adler.
diff --git a/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp b/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
index 81fad7b..7d4c01a 100644
--- a/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
+++ b/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
@@ -86,7 +86,10 @@ inline float square(float n)
 // Ideally, all of these would be fixed in the graphics layer and we would not
 // have to do any checking. You can uncomment the ENSURE_VALUE_SAFETY_FOR_SKIA
 // flag to check the graphics layer.
-#define ENSURE_VALUE_SAFETY_FOR_SKIA
+
+// Disabling these checks (20/01/2010), since we think we've fixed all the Skia
+// bugs.  Leaving the code in for now, so we can revert easily if necessary.
+// #define ENSURE_VALUE_SAFETY_FOR_SKIA
 
 static bool isCoordinateSkiaSafe(float coord)
 {

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list