[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.19-706-ge5415e9

sfalken at apple.com sfalken at apple.com
Thu Feb 4 21:25:00 UTC 2010


The following commit has been merged in the webkit-1.1 branch:
commit 7e1d4050aaeeb999b8e5f4c9447ca02ba5e7944d
Author: sfalken at apple.com <sfalken at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Fri Jan 22 19:49:56 2010 +0000

    Crash in fast/dom/Window/window-properties if Geolocation enabled
    https://bugs.webkit.org/show_bug.cgi?id=34013
    
    Reviewed by Dan Bernstein.
    
    Add null check to fix Geolocation crash in fast/dom/Window/window-properties.
    
    * page/Geolocation.cpp:
    (WebCore::createGeoposition):
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index f3fb388..27fd89a 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2010-01-22  Steve Falkenburg  <sfalken at apple.com>
+
+        Reviewed by Dan Bernstein.
+
+        Crash in fast/dom/Window/window-properties if Geolocation enabled
+        https://bugs.webkit.org/show_bug.cgi?id=34013
+        
+        Add null check to fix Geolocation crash in fast/dom/Window/window-properties.
+        
+        * page/Geolocation.cpp:
+        (WebCore::createGeoposition):
+
 2010-01-22  Kent Hansen  <kent.hansen at nokia.com>
 
         Reviewed by Darin Adler.
diff --git a/WebCore/page/Geolocation.cpp b/WebCore/page/Geolocation.cpp
index 5ff65df..a267b5f 100644
--- a/WebCore/page/Geolocation.cpp
+++ b/WebCore/page/Geolocation.cpp
@@ -48,6 +48,9 @@ static const char permissionDeniedErrorMessage[] = "User denied Geolocation";
 
 static PassRefPtr<Geoposition> createGeoposition(GeolocationPosition* position)
 {
+    if (!position)
+        return 0;
+    
     RefPtr<Coordinates> coordinates = Coordinates::create(position->latitude(), position->longitude(), position->canProvideAltitude(), position->altitude(), 
                                                           position->accuracy(), position->canProvideAltitudeAccuracy(), position->altitudeAccuracy(),
                                                           position->canProvideHeading(), position->heading(), position->canProvideSpeed(), position->speed());

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list