[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.19-706-ge5415e9
eric at webkit.org
eric at webkit.org
Thu Feb 4 21:26:02 UTC 2010
The following commit has been merged in the webkit-1.1 branch:
commit 83acc26e3e909417cc326b98c2d91f50f31f9194
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Sat Jan 23 06:35:22 2010 +0000
2010-01-22 Garret Kelly <gdk at chromium.org>
Reviewed by David Levin.
Fixing svg/custom/stroke-width-click.svg to not cause the double-click
handler to fire on certain platforms (chromium, for one). Chromium,
Leopard, and GTK all agree on the calculated extents of the shape, so I'm
disabling this test on mac-tiger and re-enabling it on mac-leopard and
updating the expected file to reflect the current state of the test.
https://bugs.webkit.org/show_bug.cgi?id=33865
* platform/mac-leopard/Skipped:
* platform/mac-tiger/Skipped:
* svg/custom/stroke-width-click-expected.txt:
* svg/custom/stroke-width-click.svg:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 3c43179..0e69314 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,19 @@
+2010-01-22 Garret Kelly <gdk at chromium.org>
+
+ Reviewed by David Levin.
+
+ Fixing svg/custom/stroke-width-click.svg to not cause the double-click
+ handler to fire on certain platforms (chromium, for one). Chromium,
+ Leopard, and GTK all agree on the calculated extents of the shape, so I'm
+ disabling this test on mac-tiger and re-enabling it on mac-leopard and
+ updating the expected file to reflect the current state of the test.
+ https://bugs.webkit.org/show_bug.cgi?id=33865
+
+ * platform/mac-leopard/Skipped:
+ * platform/mac-tiger/Skipped:
+ * svg/custom/stroke-width-click-expected.txt:
+ * svg/custom/stroke-width-click.svg:
+
2010-01-22 James Robinson <jamesr at chromium.org>
Reviewed by Alexey Proskuryakov.
diff --git a/LayoutTests/platform/mac-leopard/Skipped b/LayoutTests/platform/mac-leopard/Skipped
index d1a5cf5..f4545db 100644
--- a/LayoutTests/platform/mac-leopard/Skipped
+++ b/LayoutTests/platform/mac-leopard/Skipped
@@ -5,9 +5,6 @@ http/tests/security/frame-loading-via-document-write.html
# <rdar://problem/5686552> svg/css/glyph-orientation-rounding-test.xhtml sometimes fails
svg/css/glyph-orientation-rounding-test.xhtml
-# <rdar://problem/5539822> REGRESSION (Leopard): svg/custom/stroke-width-click.svg test failing
-svg/custom/stroke-width-click.svg
-
# Tests of table accessibility functionality not supported on Leopard
platform/mac/accessibility/table-multi-bodies.html
# Lists are not supported on Leopard.
diff --git a/LayoutTests/platform/mac-snowleopard/Skipped b/LayoutTests/platform/mac-snowleopard/Skipped
index 3a4328e..a200530 100644
--- a/LayoutTests/platform/mac-snowleopard/Skipped
+++ b/LayoutTests/platform/mac-snowleopard/Skipped
@@ -21,7 +21,6 @@ svg/batik/paints/patternRegionA.svg
svg/custom/path-bad-data.svg
svg/custom/pattern-deep-referencing.svg
svg/custom/preserve-aspect-ratio-syntax.svg
-svg/custom/stroke-width-click.svg
svg/custom/viewbox-syntax.svg
svg/hixie/perf/007.xml
svg/transforms/text-with-pattern-inside-transformed-html.xhtml
diff --git a/LayoutTests/platform/mac-tiger/Skipped b/LayoutTests/platform/mac-tiger/Skipped
index dc09efb..3294536 100644
--- a/LayoutTests/platform/mac-tiger/Skipped
+++ b/LayoutTests/platform/mac-tiger/Skipped
@@ -98,3 +98,7 @@ http/tests/media/video-error-abort.html
# Fails intermittently on Tiger Build Bot.
# https://bugs.webkit.org/show_bug.cgi?id=31412
http/tests/xmlhttprequest/logout.html
+
+# This was flagged as a regression in Leopard and Snow Leopard, but the
+# behaviour is consistent with other platforms. <rdar://problem/5539822>
+svg/custom/stroke-width-click.svg
diff --git a/LayoutTests/svg/custom/stroke-width-click-expected.txt b/LayoutTests/svg/custom/stroke-width-click-expected.txt
index 511d62f..68f65e0 100644
--- a/LayoutTests/svg/custom/stroke-width-click-expected.txt
+++ b/LayoutTests/svg/custom/stroke-width-click-expected.txt
@@ -1,14 +1,14 @@
-SUCCESS: click at 10, 10 was correctly ignored
SUCCESS: click received at: 30, 100
-SUCCESS: click at 29, 100 was correctly ignored
SUCCESS: click received at: 30, 50
-SUCCESS: click at 30, 49 was correctly ignored
SUCCESS: click received at: 30, 150
-SUCCESS: click at 30, 151 was correctly ignored
SUCCESS: click received at: 300, 100
-SUCCESS: click at 301, 100 was correctly ignored
SUCCESS: click received at: 300, 50
-SUCCESS: click at 300, 49 was correctly ignored
+SUCCESS: click received at: 301, 100
SUCCESS: click received at: 300, 150
+SUCCESS: click at 10, 10 was correctly ignored
+SUCCESS: click at 29, 100 was correctly ignored
+SUCCESS: click at 30, 49 was correctly ignored
+SUCCESS: click at 30, 151 was correctly ignored
+SUCCESS: click at 300, 49 was correctly ignored
SUCCESS: click at 300, 151 was correctly ignored
diff --git a/LayoutTests/svg/custom/stroke-width-click.svg b/LayoutTests/svg/custom/stroke-width-click.svg
index 183558d..3848915 100644
--- a/LayoutTests/svg/custom/stroke-width-click.svg
+++ b/LayoutTests/svg/custom/stroke-width-click.svg
@@ -56,21 +56,23 @@
<path d="M 30 100 L 301 100" stroke-width="100" stroke="yellow" onclick="gotClick(evt)" onmouseover="gotMouseEvent(evt, 'mouseover')" onmouseout="gotMouseEvent(evt, 'mouseout')" onmousemove="gotMouseEvent(evt, 'mousemove')" />
<text id="mouseover-text" x="30" y="190"></text>
+ <!-- The following mouse events are spaced explicity to prevent triggering double-click logic -->
<script type="text/javascript">
<![CDATA[
if (window.eventSender) {
- testClick(10, 10, false);
testClick(30, 100, true);
- testClick(29, 100, false);
testClick(30, 50, true);
- testClick(30, 49, false);
testClick(30, 150, true);
- testClick(30, 151, false);
testClick(300, 100, true);
- testClick(301, 100, false);
testClick(300, 50, true);
- testClick(300, 49, false);
+ testClick(301, 100, true);
testClick(300, 150, true);
+
+ testClick(10, 10, false);
+ testClick(29, 100, false);
+ testClick(30, 49, false);
+ testClick(30, 151, false);
+ testClick(300, 49, false);
testClick(300, 151, false);
} else {
log("ERROR: window.eventSender not found! This test must be run using DumpRenderTree. Mousing over the yellow area will log however.");
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list