[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.19-706-ge5415e9
sfalken at apple.com
sfalken at apple.com
Thu Feb 4 21:27:36 UTC 2010
The following commit has been merged in the webkit-1.1 branch:
commit e6f1dc950f8f307e57380451a42dfaee0c38bd46
Author: sfalken at apple.com <sfalken at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Jan 26 01:24:04 2010 +0000
2010-01-25 Steve Falkenburg <sfalken at apple.com>
Reviewed by Simon Fraser.
A WebGeolocationControllerClient is leaked for every WebView
https://bugs.webkit.org/show_bug.cgi?id=34145
* WebCoreSupport/WebGeolocationControllerClient.cpp:
(WebGeolocationControllerClient::geolocationDestroyed): Added.
* WebCoreSupport/WebGeolocationControllerClient.h:
2010-01-25 Steve Falkenburg <sfalken at apple.com>
Reviewed by Simon Fraser.
A WebGeolocationControllerClient is leaked for every WebView
https://bugs.webkit.org/show_bug.cgi?id=34145
* WebCoreSupport/WebGeolocationControllerClient.h:
* WebCoreSupport/WebGeolocationControllerClient.mm:
(WebGeolocationControllerClient::geolocationDestroyed):
2010-01-25 Steve Falkenburg <sfalken at apple.com>
Reviewed by Simon Fraser.
A WebGeolocationControllerClient is leaked for every WebView
https://bugs.webkit.org/show_bug.cgi?id=34145
* page/GeolocationController.cpp:
(WebCore::GeolocationController::~GeolocationController):
* page/GeolocationControllerClient.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 39c9a00..a1b7df4 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,14 @@
+2010-01-25 Steve Falkenburg <sfalken at apple.com>
+
+ Reviewed by Simon Fraser.
+
+ A WebGeolocationControllerClient is leaked for every WebView
+ https://bugs.webkit.org/show_bug.cgi?id=34145
+
+ * page/GeolocationController.cpp:
+ (WebCore::GeolocationController::~GeolocationController):
+ * page/GeolocationControllerClient.h:
+
2010-01-25 Chris Marrin <cmarrin at apple.com>
Reviewed by Simon Fraser.
diff --git a/WebCore/page/GeolocationController.cpp b/WebCore/page/GeolocationController.cpp
index 666f95e..29bc17b 100644
--- a/WebCore/page/GeolocationController.cpp
+++ b/WebCore/page/GeolocationController.cpp
@@ -40,6 +40,7 @@ GeolocationController::GeolocationController(Page* page, GeolocationControllerCl
GeolocationController::~GeolocationController()
{
+ m_client->geolocationDestroyed();
}
void GeolocationController::addObserver(Geolocation* observer)
diff --git a/WebCore/page/GeolocationControllerClient.h b/WebCore/page/GeolocationControllerClient.h
index 830c64b..cc0e1e4 100644
--- a/WebCore/page/GeolocationControllerClient.h
+++ b/WebCore/page/GeolocationControllerClient.h
@@ -32,6 +32,8 @@ class GeolocationPosition;
class GeolocationControllerClient {
public:
+ virtual void geolocationDestroyed() = 0;
+
virtual void startUpdating() = 0;
virtual void stopUpdating() = 0;
virtual GeolocationPosition* lastPosition() = 0;
diff --git a/WebKit/mac/ChangeLog b/WebKit/mac/ChangeLog
index e3857ea..cda13d7 100644
--- a/WebKit/mac/ChangeLog
+++ b/WebKit/mac/ChangeLog
@@ -1,3 +1,14 @@
+2010-01-25 Steve Falkenburg <sfalken at apple.com>
+
+ Reviewed by Simon Fraser.
+
+ A WebGeolocationControllerClient is leaked for every WebView
+ https://bugs.webkit.org/show_bug.cgi?id=34145
+
+ * WebCoreSupport/WebGeolocationControllerClient.h:
+ * WebCoreSupport/WebGeolocationControllerClient.mm:
+ (WebGeolocationControllerClient::geolocationDestroyed):
+
2010-01-22 Steve Falkenburg <sfalken at apple.com>
Reviewed by Darin Adler.
diff --git a/WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h b/WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h
index 89944f0..3965210 100644
--- a/WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h
+++ b/WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h
@@ -36,6 +36,7 @@ public:
WebGeolocationControllerClient(WebView *);
WebView *webView() { return m_webView; }
+ void geolocationDestroyed();
void startUpdating();
void stopUpdating();
diff --git a/WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.mm b/WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.mm
index 3291418..98ffc72 100644
--- a/WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.mm
+++ b/WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.mm
@@ -35,6 +35,11 @@ WebGeolocationControllerClient::WebGeolocationControllerClient(WebView *webView)
{
}
+void WebGeolocationControllerClient::geolocationDestroyed()
+{
+ delete this;
+}
+
void WebGeolocationControllerClient::startUpdating()
{
[[m_webView _geolocationProvider] registerWebView:m_webView];
diff --git a/WebKit/win/ChangeLog b/WebKit/win/ChangeLog
index eb64e43..cb01809 100644
--- a/WebKit/win/ChangeLog
+++ b/WebKit/win/ChangeLog
@@ -1,3 +1,14 @@
+2010-01-25 Steve Falkenburg <sfalken at apple.com>
+
+ Reviewed by Simon Fraser.
+
+ A WebGeolocationControllerClient is leaked for every WebView
+ https://bugs.webkit.org/show_bug.cgi?id=34145
+
+ * WebCoreSupport/WebGeolocationControllerClient.cpp:
+ (WebGeolocationControllerClient::geolocationDestroyed): Added.
+ * WebCoreSupport/WebGeolocationControllerClient.h:
+
2010-01-23 Dan Bernstein <mitz at apple.com>
Reviewed by Maciej Stachowiak.
diff --git a/WebKit/win/WebCoreSupport/WebGeolocationControllerClient.cpp b/WebKit/win/WebCoreSupport/WebGeolocationControllerClient.cpp
index ed98434..db5ed90 100644
--- a/WebKit/win/WebCoreSupport/WebGeolocationControllerClient.cpp
+++ b/WebKit/win/WebCoreSupport/WebGeolocationControllerClient.cpp
@@ -37,6 +37,11 @@ WebGeolocationControllerClient::WebGeolocationControllerClient(WebView* webView)
{
}
+void WebGeolocationControllerClient::geolocationDestroyed()
+{
+ delete this;
+}
+
void WebGeolocationControllerClient::startUpdating()
{
COMPtr<IWebGeolocationProvider> provider;
diff --git a/WebKit/win/WebCoreSupport/WebGeolocationControllerClient.h b/WebKit/win/WebCoreSupport/WebGeolocationControllerClient.h
index 19bc6f1..ec0bef7 100644
--- a/WebKit/win/WebCoreSupport/WebGeolocationControllerClient.h
+++ b/WebKit/win/WebCoreSupport/WebGeolocationControllerClient.h
@@ -39,6 +39,7 @@ class WebGeolocationControllerClient : public WebCore::GeolocationControllerClie
public:
WebGeolocationControllerClient(WebView*);
+ virtual void geolocationDestroyed();
virtual void startUpdating();
virtual void stopUpdating();
virtual WebCore::GeolocationPosition* lastPosition();
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list