[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.19-706-ge5415e9
eric at webkit.org
eric at webkit.org
Thu Feb 4 21:32:29 UTC 2010
The following commit has been merged in the webkit-1.1 branch:
commit bbc718aa8ca126a2a4bb45a9a854b030b0870409
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri Jan 29 18:13:10 2010 +0000
2010-01-29 Drew Wilson <atwilson at chromium.org>
Reviewed by Adam Barth.
V8 implementation of MessageEvent.initMessageEvent() does not set source correctly.
https://bugs.webkit.org/show_bug.cgi?id=34292
Test: fast/events/init-events.html will pass in Chrome now.
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::initMessageEventCallback):
Now properly extracts the reference to the DOMWindow object from the passed-in window parameter.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 501a634..0852b35 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2010-01-29 Drew Wilson <atwilson at chromium.org>
+
+ Reviewed by Adam Barth.
+
+ V8 implementation of MessageEvent.initMessageEvent() does not set source correctly.
+ https://bugs.webkit.org/show_bug.cgi?id=34292
+
+ Test: fast/events/init-events.html will pass in Chrome now.
+
+ * bindings/v8/custom/V8MessageEventCustom.cpp:
+ (WebCore::V8MessageEvent::initMessageEventCallback):
+ Now properly extracts the reference to the DOMWindow object from the passed-in window parameter.
+
2010-01-29 Ben Murdoch <benm at google.com>
Reviewed by Dimitri Glazkov.
diff --git a/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp b/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp
index 2b027dc..9e40855 100644
--- a/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp
+++ b/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp
@@ -68,7 +68,14 @@ v8::Handle<v8::Value> V8MessageEvent::initMessageEventCallback(const v8::Argumen
RefPtr<SerializedScriptValue> dataArg = SerializedScriptValue::create(args[3]);
String originArg = v8ValueToWebCoreString(args[4]);
String lastEventIdArg = v8ValueToWebCoreString(args[5]);
- DOMWindow* sourceArg = V8DOMWindow::HasInstance(args[6]) ? V8DOMWindow::toNative(v8::Handle<v8::Object>::Cast(args[6])) : 0;
+
+ DOMWindow* sourceArg = 0;
+ if (args[6]->IsObject()) {
+ v8::Handle<v8::Object> wrapper = v8::Handle<v8::Object>::Cast(args[6]);
+ v8::Handle<v8::Object> window = V8DOMWrapper::lookupDOMWrapper(V8ClassIndex::DOMWINDOW, wrapper);
+ if (!window.IsEmpty())
+ sourceArg = V8DOMWindow::toNative(window);
+ }
OwnPtr<MessagePortArray> portArray;
if (!isUndefinedOrNull(args[7])) {
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list