[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.19-706-ge5415e9
steveblock at google.com
steveblock at google.com
Thu Feb 4 21:36:34 UTC 2010
The following commit has been merged in the webkit-1.1 branch:
commit 182abdc9c13e1c0753ab3c02fd1dd2da1953d816
Author: steveblock at google.com <steveblock at google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Feb 2 09:58:28 2010 +0000
Adds virtual destructors for AbstractWeakReferenceMap and AbstractWeakReferenceMap::Visitor
https://bugs.webkit.org/show_bug.cgi?id=34434
Reviewed by Adam Barth.
No new tests, build fix only.
* bindings/v8/V8DOMMap.h: Modified.
(WebCore::AbstractWeakReferenceMap::~AbstractWeakReferenceMap): Added.
(WebCore::AbstractWeakReferenceMap::Visitor::~Visitor): Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 2cc4b18..0872f76 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2010-02-02 Steve Block <steveblock at google.com>
+
+ Reviewed by Adam Barth.
+
+ Adds virtual destructors for AbstractWeakReferenceMap and AbstractWeakReferenceMap::Visitor
+ https://bugs.webkit.org/show_bug.cgi?id=34434
+
+ No new tests, build fix only.
+
+ * bindings/v8/V8DOMMap.h: Modified.
+ (WebCore::AbstractWeakReferenceMap::~AbstractWeakReferenceMap): Added.
+ (WebCore::AbstractWeakReferenceMap::Visitor::~Visitor): Added.
+
2010-02-02 Avi Drissman <avi at chromium.org>
Reviewed by Eric Seidel.
diff --git a/WebCore/bindings/v8/V8DOMMap.h b/WebCore/bindings/v8/V8DOMMap.h
index d42daa4..a7e03a0 100644
--- a/WebCore/bindings/v8/V8DOMMap.h
+++ b/WebCore/bindings/v8/V8DOMMap.h
@@ -44,10 +44,13 @@ namespace WebCore {
template <class KeyType, class ValueType> class AbstractWeakReferenceMap {
public:
AbstractWeakReferenceMap(v8::WeakReferenceCallback callback) : m_weakReferenceCallback(callback) { }
+ virtual ~AbstractWeakReferenceMap() { }
class Visitor {
public:
virtual void visitDOMWrapper(KeyType* key, v8::Persistent<ValueType> object) = 0;
+ protected:
+ virtual ~Visitor() { }
};
virtual v8::Persistent<ValueType> get(KeyType* obj) = 0;
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list