[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.21-584-g1e41756

steveblock at google.com steveblock at google.com
Fri Feb 26 22:17:49 UTC 2010


The following commit has been merged in the webkit-1.1 branch:
commit c89da902a274b9f69087683424e102c95a1c79ff
Author: steveblock at google.com <steveblock at google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Feb 11 18:27:49 2010 +0000

    Fixes CodeGeneratorV8.pm to include the header for the indexer type when using setCollectionIndexedGetter()
    https://bugs.webkit.org/show_bug.cgi?id=34836
    
    setCollectionIndexedGetter() uses getIndexedPropertyOfCollection(),
    which in turn uses toV8() with the indexer type, which is declared in
    the header for the indexer type.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index f3e41d3..1ddf9d5 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,18 @@
+2010-02-11  Steve Block  <steveblock at google.com>
+
+        Reviewed by Dimitri Glazkov.
+
+        Fixes CodeGeneratorV8.pm to include the header for the indexer type when using setCollectionIndexedGetter()
+        https://bugs.webkit.org/show_bug.cgi?id=34836
+
+        setCollectionIndexedGetter() uses getIndexedPropertyOfCollection(),
+        which in turn uses toV8() with the indexer type, which is declared in
+        the header for the indexer type.
+
+        No new tests, build fix only.
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+
 2010-02-11  Pavel Feldman  <pfeldman at chromium.org>
 
         Reviewed by Timothy Hatcher.
diff --git a/WebCore/bindings/scripts/CodeGeneratorV8.pm b/WebCore/bindings/scripts/CodeGeneratorV8.pm
index 3580e34..0146094 100644
--- a/WebCore/bindings/scripts/CodeGeneratorV8.pm
+++ b/WebCore/bindings/scripts/CodeGeneratorV8.pm
@@ -1325,6 +1325,8 @@ END
             push(@implContent, <<END);
   setCollectionIndexedGetter<${interfaceName}, ${indexerType}>(desc, V8ClassIndex::${indexerClassIndex});
 END
+            # Include the header for this indexer type, because setCollectionIndexedGetter() requires toV8() for this type.
+            $implIncludes{"V8${indexerType}.h"} = 1;
         }
 
         return;

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list