[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.21-584-g1e41756
ap at apple.com
ap at apple.com
Fri Feb 26 22:25:46 UTC 2010
The following commit has been merged in the webkit-1.1 branch:
commit 09b6f5d001075a7b6346f4472b70512763ecce33
Author: ap at apple.com <ap at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri Feb 19 18:59:24 2010 +0000
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=35165
plugins/set-status.html fails on Windows bot
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::status):
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView status:]):
Match Windows port behavior (and also Firefox one, in a way) - pass null status messages as
empty ones to chrome.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index ead858c..bea14c9 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,12 @@
+2010-02-19 Alexey Proskuryakov <ap at apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=35165
+ plugins/set-status.html fails on Windows bot
+
+ * plugins/set-status-expected.txt: The behavior of Windows port was better, changed expectations.
+
2010-02-19 Andras Becsi <abecsi at webkit.org>
Reviewed by Kenneth Rohde Christiansen.
diff --git a/LayoutTests/plugins/set-status-expected.txt b/LayoutTests/plugins/set-status-expected.txt
index 9bfe6ac..9e1cc90 100644
--- a/LayoutTests/plugins/set-status-expected.txt
+++ b/LayoutTests/plugins/set-status-expected.txt
@@ -1,3 +1,4 @@
+UI DELEGATE STATUS CALLBACK: setStatusText:
UI DELEGATE STATUS CALLBACK: setStatusText:PАSS
PASS if status bar says "PASS".
diff --git a/WebKit/mac/ChangeLog b/WebKit/mac/ChangeLog
index 1b6590d..e42c190 100644
--- a/WebKit/mac/ChangeLog
+++ b/WebKit/mac/ChangeLog
@@ -1,3 +1,17 @@
+2010-02-19 Alexey Proskuryakov <ap at apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=35165
+ plugins/set-status.html fails on Windows bot
+
+ * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
+ (WebKit::NetscapePluginInstanceProxy::status):
+ * Plugins/WebNetscapePluginView.mm:
+ (-[WebNetscapePluginView status:]):
+ Match Windows port behavior (and also Firefox one, in a way) - pass null status messages as
+ empty ones to chrome.
+
2010-02-18 Simon Fraser <simon.fraser at apple.com>
Reviewed by Dan Bernstein.
diff --git a/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm b/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm
index 766cfce..515f9f7 100644
--- a/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm
+++ b/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm
@@ -504,9 +504,7 @@ void NetscapePluginInstanceProxy::stopTimers()
void NetscapePluginInstanceProxy::status(const char* message)
{
- if (!message)
- return;
- RetainPtr<CFStringRef> status(AdoptCF, CFStringCreateWithCString(0, message, kCFStringEncodingUTF8));
+ RetainPtr<CFStringRef> status(AdoptCF, CFStringCreateWithCString(0, message ? message : "", kCFStringEncodingUTF8));
if (!status)
return;
diff --git a/WebKit/mac/Plugins/WebNetscapePluginView.mm b/WebKit/mac/Plugins/WebNetscapePluginView.mm
index 613f235..8fb1503 100644
--- a/WebKit/mac/Plugins/WebNetscapePluginView.mm
+++ b/WebKit/mac/Plugins/WebNetscapePluginView.mm
@@ -1904,12 +1904,7 @@ static inline void getNPRect(const NSRect& nr, NPRect& npr)
-(void)status:(const char *)message
{
- if (!message) {
- LOG_ERROR("NPN_Status passed a NULL status message");
- return;
- }
-
- CFStringRef status = CFStringCreateWithCString(NULL, message, kCFStringEncodingUTF8);
+ CFStringRef status = CFStringCreateWithCString(NULL, message ? message : "", kCFStringEncodingUTF8);
if (!status) {
LOG_ERROR("NPN_Status: the message was not valid UTF-8");
return;
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list