[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.17-1283-gcf603cf
weinig at apple.com
weinig at apple.com
Tue Jan 5 23:40:06 UTC 2010
The following commit has been merged in the webkit-1.1 branch:
commit f082324b8acb807983cdb223fa445d218af99e9b
Author: weinig at apple.com <weinig at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Dec 1 23:36:15 2009 +0000
Simplify [WebView userAgentForURL:]. No need to call into helper function.
Reviewed by Mark Rowe.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::userAgent):
* WebView/WebView.mm:
(-[WebView userAgentForURL:]):
* WebView/WebViewInternal.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKit/mac/ChangeLog b/WebKit/mac/ChangeLog
index d87d7ac..44dcb62 100644
--- a/WebKit/mac/ChangeLog
+++ b/WebKit/mac/ChangeLog
@@ -1,3 +1,15 @@
+2009-12-01 Sam Weinig <sam at webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Simplify [WebView userAgentForURL:]. No need to call into helper function.
+
+ * WebCoreSupport/WebFrameLoaderClient.mm:
+ (WebFrameLoaderClient::userAgent):
+ * WebView/WebView.mm:
+ (-[WebView userAgentForURL:]):
+ * WebView/WebViewInternal.h:
+
2009-11-24 Gavin Barraclough <barraclough at apple.com>
Reviewed by Geoff Garen.
diff --git a/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm b/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
index e93d177..b3aa1ce 100644
--- a/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
+++ b/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
@@ -1224,7 +1224,7 @@ String WebFrameLoaderClient::userAgent(const KURL& url)
if (!webView)
return String("");
- return [webView _userAgentForURL:url];
+ return [webView userAgentForURL:url];
}
static const MouseEvent* findMouseEvent(const Event* event)
diff --git a/WebKit/mac/WebView/WebView.mm b/WebKit/mac/WebView/WebView.mm
index 3623da7..68208f6 100644
--- a/WebKit/mac/WebView/WebView.mm
+++ b/WebKit/mac/WebView/WebView.mm
@@ -3197,7 +3197,14 @@ static bool needsWebViewInitThreadWorkaround()
// Get the appropriate user-agent string for a particular URL.
- (NSString *)userAgentForURL:(NSURL *)url
{
- return [self _userAgentForURL:KURL([url absoluteURL])];
+ if (_private->useSiteSpecificSpoofing) {
+ // No current site-specific spoofs.
+ }
+
+ if (_private->userAgent.isNull())
+ _private->userAgent = [[self class] _standardUserAgentWithApplicationName:_private->applicationNameForUserAgent];
+
+ return _private->userAgent;
}
- (void)setHostWindow:(NSWindow *)hostWindow
@@ -5299,19 +5306,6 @@ static WebFrameView *containingFrameView(NSView *view)
}
#endif // ENABLE(ICONDATABASE)
-// Get the appropriate user-agent string for a particular URL.
-- (WebCore::String)_userAgentForURL:(const WebCore::KURL&)url
-{
- if (_private->useSiteSpecificSpoofing) {
- // No current site-specific spoofs.
- }
-
- if (_private->userAgent.isNull())
- _private->userAgent = [[self class] _standardUserAgentWithApplicationName:_private->applicationNameForUserAgent];
-
- return _private->userAgent;
-}
-
- (void)_addObject:(id)object forIdentifier:(unsigned long)identifier
{
ASSERT(!_private->identifierMap.contains(identifier));
diff --git a/WebKit/mac/WebView/WebViewInternal.h b/WebKit/mac/WebView/WebViewInternal.h
index 15596db..0665831 100644
--- a/WebKit/mac/WebView/WebViewInternal.h
+++ b/WebKit/mac/WebView/WebViewInternal.h
@@ -67,7 +67,6 @@ namespace WebCore {
- (WebCore::Frame*)_mainCoreFrame;
- (WebFrame *)_selectedOrMainFrame;
-- (WebCore::String)_userAgentForURL:(const WebCore::KURL&)url;
- (WebCore::KeyboardUIMode)_keyboardUIMode;
- (BOOL)_becomingFirstResponderFromOutside;
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list